Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Extend AlertPopupView to include an option to enter user text #1298

Closed
jumde opened this issue Jul 25, 2019 · 2 comments
Closed

Extend AlertPopupView to include an option to enter user text #1298

jumde opened this issue Jul 25, 2019 · 2 comments
Labels
enhancement QA/No release-notes/exclude
Milestone
1.11.3

Comments

@jumde
Copy link
Contributor

jumde commented Jul 25, 2019

Description:

UserTextInputAlert dialogs are spoof-able, the dialogs look very similar to prompt() alerts in javascript. We should update AlertPopupView to include an option for user to enter text to differentiate browser alerts from alerts from web pages.
@jumde
Copy link
Contributor Author

jumde commented Jul 25, 2019 •
edited
Loading

Currently UserTextInputAlerts are used in bookmarks, favorites cc: @jamesmudgett @tomlowenthal @jhreis

@danishjafri88
Copy link
Contributor

@jumde have an experimental implementation here: #690

@jhreis jhreis added this to the 1.12 milestone Aug 8, 2019
@iccub iccub closed this as completed in 204da56 Aug 8, 2019
@jhreis jhreis modified the milestones: 1.12, 1.11.1 Aug 10, 2019
jhreis pushed a commit that referenced this issue Aug 10, 2019
@jamesmudgett @jhreis
Fix #1298: Text input support for AlertPopupView (#1341)
7bf173e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement QA/No release-notes/exclude
Projects
None yet
Milestone
1.11.3
Development

No branches or pull requests
3 participants
@jumde @jhreis @danishjafri88