Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #1373: Set dummy tab id for private mode browsing. #1375

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Aug 11, 2019

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • My patch or PR title has a standard commit message that looks like Fix #123: This fixes the shattered coffee cup! (or No Bug: <message> if no relevant ticket)
  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New files have MPL-2.0 license header.

Test Plan:

Screenshots:

Reviewer Checklist:

  • PR is linked to an issue via Zenhub.
  • Issues are assigned to at least one epic.
  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable)

@iccub
Copy link
Contributor Author

iccub commented Aug 11, 2019

Please test yubikey functionality before merging, I tested regular browsing activity, moving tabs, restoring..

@jumde
Copy link
Contributor

jumde commented Aug 11, 2019

Please test yubikey functionality before merging, I tested regular browsing activity, moving tabs, restoring..

Works with YubiKey

@iccub
Copy link
Contributor Author

iccub commented Aug 12, 2019

@jhreis do we merge to development or to a hotfix branch?

@jhreis jhreis merged commit 435b67a into development Aug 12, 2019
@jhreis jhreis deleted the bugfix/1373 branch August 12, 2019 18:38
@kjozwiak kjozwiak added this to the 1.11.1 milestone Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants