Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #1217: Support PINs for security keys #1303

Merged
merged 3 commits into from
Aug 6, 2019
Merged

Fix #1217: Support PINs for security keys #1303

merged 3 commits into from
Aug 6, 2019

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Jul 26, 2019

fix #1217

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • My patch or PR title has a standard commit message that looks like Fix #123: This fixes the shattered coffee cup! (or No Bug: <message> if no relevant ticket)
  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New files have MPL-2.0 license header.

Test Plan:

  1. Set a PIN on your YubiKey using Yubikey Manager
  2. Navigate to demo.yubico.com/u2f/
  3. Confirm that a PIN is prompted during the registration workflow.
  4. Entering a correct PIN should successfully complete registration
  5. Entering an incorrect PIN should throw an error.

Screenshots:

Screen Shot 2019-07-30 at 12 16 06 PM

Screen Shot 2019-07-30 at 12 16 14 PM

Reviewer Checklist:

  • PR is linked to an issue via Zenhub.
  • Issues are assigned to at least one epic.
  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable)

@jumde jumde self-assigned this Jul 26, 2019
@jumde jumde added the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Jul 30, 2019
@jumde jumde added QA/Yes and removed blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue labels Aug 1, 2019
@jumde jumde requested a review from Brandon-T August 1, 2019 22:08
@jumde
Copy link
Contributor Author

jumde commented Aug 1, 2019

Added a small change for exclude credentials: 949394d

@Brandon-T Exclude Credentials is optional for the registration request, so using an Optional type. Let me know if you have any concerns.

Client/U2FExtensions.swift Show resolved Hide resolved
Client/U2FExtensions.swift Show resolved Hide resolved
Client/U2FExtensions.swift Outdated Show resolved Hide resolved
Client/U2FExtensions.swift Show resolved Hide resolved
Client/U2FExtensions.swift Show resolved Hide resolved
Client/U2FExtensions.swift Show resolved Hide resolved
@iccub iccub removed the QA/Yes label Aug 6, 2019
@iccub iccub merged commit ba8d1c6 into development Aug 6, 2019
@iccub iccub deleted the u2f_pin branch August 6, 2019 10:39
@iccub iccub modified the milestone: 1.12 Aug 7, 2019
jhreis pushed a commit that referenced this pull request Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PINS don't work with YubiKeys
3 participants