Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

App crashes on Switching back to normal mode from PBM. #1309

Closed
danishjafri88 opened this issue Jul 30, 2019 · 2 comments · Fixed by #1310
Closed

App crashes on Switching back to normal mode from PBM. #1309

danishjafri88 opened this issue Jul 30, 2019 · 2 comments · Fixed by #1310
Assignees
@danishjafri88
Labels
bug QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.11.3

Comments

@danishjafri88
Copy link
Contributor

danishjafri88 commented Jul 30, 2019 •
edited
Loading

App crashes when switching to normal mode from PBM.
Inferred crash due to changes in #1024

Description:

Steps to Reproduce

  1. Open PBM
  2. Open a Site
  3. Open Tab tray
  4. Tap to change mode

Actual result:
Crash

Expected result:
Mode Changed to normal

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
danishjafri88 added a commit that referenced this issue Jul 30, 2019
@danishjafri88
Fixes #1309 by making sure NSBatchDeleteRequest is not run on In-Memo…
7f3d5d9 
…ry store. And other cleanups.
@danishjafri88 danishjafri88 mentioned this issue Jul 30, 2019
Merged
14 tasks
@danishjafri88 danishjafri88 self-assigned this Jul 30, 2019
@danishjafri88 danishjafri88 added this to the 1.10 milestone Jul 30, 2019
iccub pushed a commit that referenced this issue Jul 30, 2019
@danishjafri88 @iccub
Fix #1309: Don't use NSBatchDeleteRequest on In-Memory store(#1310)
5eb1d7a
@jhreis jhreis modified the milestones: 1.10, 1.12 Jul 31, 2019
@anthonypkeane
Copy link

dup of #1353

@jhreis jhreis mentioned this issue Aug 8, 2019
Closed
@jhreis jhreis modified the milestones: 1.12, 1.11.1 Aug 9, 2019
@srirambv
Copy link
Contributor

srirambv commented Aug 10, 2019 •
edited by LaurenWags
Loading

  • Verification passed on iPhone 7+ running 1.12

    • Verified no crash when exiting private tabs
    • Verified long press on a link and select open in private tab, then exit private tab doesn't crash
    • Verified opening a private tab from 3D touch on the home screen and exit private tab doesn't crash
    • Verified setting PB only mode visiting a site and then disable PB mode only doesn't crash
    • Verified opening tab tray and selecting private and visiting a site, then exit private tab via tray doesn't crash the browser

  • Verified passed with iPad 5th Gen using 1.11.1 (19.08.13.17)

    • Verified no crash when exiting private tabs
    • Verified long press on a link and select open in private tab, then exit private tab doesn't crash
    • Verified setting PB only mode visiting a site and then disable PB mode only doesn't crash
    • Verified opening tab tray and selecting private and visiting a site, then exit private tab via tray doesn't crash the browser

jhreis pushed a commit that referenced this issue Aug 10, 2019
@danishjafri88 @jhreis
Fix #1309: Don't use NSBatchDeleteRequest on In-Memory store(#1310)
96b151f
@srirambv srirambv mentioned this issue Aug 19, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@danishjafri88 danishjafri88

Labels
bug QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.11.3
Development

Successfully merging a pull request may close this issue.

Fixes #1309 by making sure NSBatchDeleteRequest is not run on In-Memory store brave/brave-ios
5 participants
@jhreis @danishjafri88 @anthonypkeane @srirambv @LaurenWags