Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change region field required to default_from_api #10718

Closed
wants to merge 361 commits into from
Closed

Change region field required to default_from_api #10718

wants to merge 361 commits into from

Conversation

pawelJas
Copy link
Contributor

Change region field for google_compute_region_ssl_policy to be optional and to be inferred from environment.

Fixes hashicorp/terraform-provider-google#17142

  • Searched through the issue tracker for an open issue that this either resolves or contributes.
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests). - read only field
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: Allowed `region` field to `google_compute_region_ssl_policy` resource to be inferred from environment

@github-actions github-actions bot requested a review from roaks3 May 16, 2024 14:13
@github-actions GitHub Actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

melinath and others added 28 commits May 16, 2024 15:16
@melinath @pawelJas
Add trodge to vacation list (GoogleCloudPlatform#10384)
7da7e66
@ScottSuarez @pawelJas
Add sweeper for firestore_database_instance (GoogleCloudPlatform#10380)
5e17c58
@maxi-cit @pawelJas
add billing_project_id to basic firewall endpoint example (GoogleClou…
89ec9f8 
…dPlatform#10343)
@zli82016 @pawelJas
Convert example templates (part 2) (GoogleCloudPlatform#10381)
51c8afe
@SarahFrench @pawelJas
Refactor acceptance tests to avoid google_project_iam_binding and oth…
d06e985 
…er *_iam_binding IAM resources (GoogleCloudPlatform#10314)
@melinath @pawelJas
Made TestAccLoggingProjectSink_default use a separate project (Google…
96c6c83 
…CloudPlatform#10386)
@melinath @pawelJas
Increased google_compute_security_policy timeouts to 20 minutes (defa…
64f0a7c 
…ult) (GoogleCloudPlatform#10385)
@gfxcc @pawelJas
Add ignore_read_extra for subordinate_config (GoogleCloudPlatform#10390)
4cf16b9
@pwschuurman @pawelJas
Add support for GKE Addon StatefulHA (GoogleCloudPlatform#9481)
f50e1ed
@Gorlami96 @zli82016 @pawelJas
Adding ipv6 support for bgp router peer, router interface and router (G…
4310fa3 
…oogleCloudPlatform#10375)

Co-authored-by: Shivang Dixit <[email protected]>
Co-authored-by: Zhenhua Li <[email protected]>
@rsm3171990 @pawelJas
Add enable_google_ml_integration setting to google_sql_database_insta… (
811be5d 
GoogleCloudPlatform#10383)
@unnatinadupalli @SarahFrench @pawelJas
Adding Parallelstore Beta Service Provider (GoogleCloudPlatform#9910)
62a93a4 
Co-authored-by: Sarah French <[email protected]>
@iyabchen @melinath @pawelJas
support vacation time range for reviewers (GoogleCloudPlatform#10355)
9e35833 
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
@swamitagupta @pawelJas
Add support for Vmwareengine Stretch Private Clouds. (GoogleCloudPlat…
77b8f13 
…form#10340)
@cmfeng @pawelJas
Add Smart Scheduling feature in BackupPlan for Backup for GKE (Google…
ab2f0d8 
…CloudPlatform#10247)
@zli82016 @pawelJas
Convert example templates (part 3) (GoogleCloudPlatform#10391)
6bbeaa4
@EladLeev @pawelJas
feat: add labels validations (GoogleCloudPlatform#10387)
b2a9de9
@melinath @pawelJas
Return affected resources from diff-processor instead of labels (Goog…
b5c7463 
…leCloudPlatform#10311)
@zli82016 @pawelJas
Convert example templates (part 4) (GoogleCloudPlatform#10392)
679999a
@spapi17 @pawelJas
Minor fix to address ambiguity in error message. (GoogleCloudPlatform…
f6dcc84 
…#10389)
@harshulsoni @pawelJas
Change supported machine type to fix CHD tests. (GoogleCloudPlatform#…
345ddec 
…10404)
@SarahFrench @pawelJas
Fix issue in GA version of resource_parallelstore_instance_test.go (G…
a00a587 
…oogleCloudPlatform#10406)
@zli82016 @pawelJas
Convert example templates (part 5) (GoogleCloudPlatform#10398)
3df8637
@hao-nan-li @pawelJas
Replace DCL configured basePath by the corresponding universe domain (G…
426991a 
…oogleCloudPlatform#10400)
@tdbhacks @pawelJas
Drop IAM resources from EkmConnection tests. (GoogleCloudPlatform#10407)
2031e83
@zli82016 @pawelJas
Show diff for computed nested labels fields when creating resources (G…
b4b4568 
…oogleCloudPlatform#10401)
@efeelaiho @pawelJas
Set no prefix to fix "IP range no free block error" for test of looke…
37b9664 
…r enterprise (GoogleCloudPlatform#10365)
@melinath @pawelJas
Allowed modifying request headers via pre_create, pre_read, pre_updat…
2eb0de8 
…e, or pre_delete custom code (GoogleCloudPlatform#10405)
melinath and others added 29 commits May 16, 2024 15:16
@melinath @pawelJas
Fixed color formatting for VCR test results (GoogleCloudPlatform#10681)
9911f35
@apeabody @pawelJas
docs: correct nested_bundles (GoogleCloudPlatform#10667)
c7dc1f3
@zli82016 @pawelJas
Remove slashes in titles in resource docs (GoogleCloudPlatform#10657)
68bead7
@zli82016 @pawelJas
Sort parameters in oics link and remove white spaces in generated Go …
4fcc29f 
…files (GoogleCloudPlatform#10662)
@delimaneto @pawelJas
Add Suport for google_compute_node_template to TGC (GoogleCloudPlat…
471f392 
…form#10602)
@dvfons @pawelJas
Add support for google_compute_vpn_tunnel to TGC (GoogleCloudPlatfo…
4263768 
…rm#10618)
@shuyama1 @c2thorn @pawelJas
added functionality in mmv1 to support configurable sweepers (GoogleC…
9c42208 
…loudPlatform#10650)

Co-authored-by: Cameron Thornton <[email protected]>
@synth-beat @pawelJas
Remove min_master_version from stack type tests (GoogleCloudPlatform#…
5d08ce3 
…10630)
@kautikdk @pawelJas
Fixes storage bucket custom_time_before/noncurrent_time_before update…
393cfd2 
… issue (GoogleCloudPlatform#10601)
@averbuks @pawelJas
Promote google_cloud_asset_resources_search_all datasource to ga (Goo…
ecfc0ce 
…gleCloudPlatform#10660)
@melinath @pawelJas
Added note about ProviderFactories to test promotion docs (GoogleClou…
4bb6e31 
…dPlatform#10688)
@melinath @pawelJas
Switched to using channel-based versions for TestAccContainerCluster_…
37f5df6 
…updateVersion (GoogleCloudPlatform#10689)
@trodge @pawelJas
Revert "Add reservedInternalRange fields to the google_compute_subnet…
c7ce021 
…work resource" (GoogleCloudPlatform#10697)
@LucaPrete @pawelJas
Revert "Adding self_link output to google_network_security profile gr…
1b649f0 
…oup" (GoogleCloudPlatform#10696)
@Harwayne @pawelJas
Add local_ssd_interface to Dataproc Cluster's disk_config. (Googl…
2b33407 
…eCloudPlatform#10663)
@c2thorn @pawelJas
Go rewrite - resource custom code blocks and various diffs (GoogleClo…
58a55bf 
…udPlatform#10676)
@maxi-cit @pweiber @pawelJas
Add lb traffic extension resource (GoogleCloudPlatform#10121)
68b958b 
Co-authored-by: pweiber <[email protected]>
@maxi-cit @pawelJas
adds NGFW support for google_network_security_tls_inspection_policy r…
4db5127 
…esource (GoogleCloudPlatform#9864)
@marblejenka @pawelJas
Support V5P for type of accelerator_config in google_tpu_v2_vm (Googl…
a1df0a9 
…eCloudPlatform#10333)
@shuyama1 @rileykarson @pawelJas
added documentation for updating go.mod (GoogleCloudPlatform#10673)
58b4201 
Co-authored-by: Riley Karson <[email protected]>
@melinath @pawelJas
Update PERFORMING_TASKS_IN_TEAMCITY.md (GoogleCloudPlatform#10700)
aa30cf2
@melinath @pawelJas
Enabled live PR review notifications (GoogleCloudPlatform#10690)
66fab11
@dvfons @pawelJas
Add support for google_service_account_key to TGC (GoogleCloudPlatf…
be9df16 
…orm#10693)
@SarahFrench @pawelJas
Add guard against trying to upload non-existant artifacts to GCS (Goo…
2d114bf 
…gleCloudPlatform#10677)
@iyabchen @pawelJas
chore(ci): use wait for commit go version in downstream ci (GoogleClo…
40977a7 
…udPlatform#10682)
@rileykarson @pawelJas
Add context to IAM steps in contribution guide (GoogleCloudPlatform#1…
b6719b2 
…0709)
@bestefreund @pawelJas
Add data source for retrieving multiple GCE subnetworks (GoogleCloudP…
e560e94 
…latform#10669)
@vivzbansal @mmiranda96 @pawelJas
Add support for PrivateRegistryAccessConfig (GoogleCloudPlatform#10591)
23dad9d 
Co-authored-by: Mike Miranda <[email protected]>
@SarahFrench @pawelJas
Add more detail to TeamCity docs on how to run custom builds (GoogleC…
16810e5 
…loudPlatform#10704)
@pawelJas pawelJas closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roaks3 roaks3 Awaiting requested review from roaks3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone