Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set no prefix to fix "IP range no free block error" for test of looker enterprise #10365

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Conversation

efeelaiho
Copy link
Contributor

@efeelaiho efeelaiho commented Apr 4, 2024

Set no prefix to fix IP range no free block error

Fixes hashicorp/terraform-provider-google#17394

Error to resolve:

Error: Error waiting to create Instance: Error waiting for Creating Instance: Error code 9, message: 

Couldn't find free blocks in requested range '10.209.49.0/25'. 
Please allocate new ranges for this service provider.

Release Note Template for Downstream PRs (will be copied)


@github-actions github-actions bot requested a review from shuyama1 April 4, 2024 01:33
Copy link

github-actions bot commented Apr 4, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@shuyama1
Copy link
Member

shuyama1 commented Apr 8, 2024

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 5
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • looker

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@@ -69,9 +69,9 @@ examples:
client_id: 'my-client-id'
client_secret: 'my-client-secret'
test_vars_overrides:
address_name: 'acctest.BootstrapSharedTestGlobalAddress(t, "looker-vpc-network-1", acctest.AddressWithPrefixLength(20))'
address_name: 'acctest.BootstrapSharedTestGlobalAddress(t, "looker-vpc-network-1")'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to change the name looker-vpc-network-1 to something else to test if this works, as based on how we set up the bootstrapped resource, they won't get recreated without the name changed (we'll read the resource first and only create a new one if no existing one is found)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shuyama1 Okay, done!

@github-actions github-actions bot requested a review from shuyama1 April 10, 2024 15:12
@shuyama1
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 4
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • looker

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@shuyama1 shuyama1 merged commit 1c575ec into GoogleCloudPlatform:main Apr 10, 2024
12 checks passed
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample
3 participants