-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set no prefix to fix "IP range no free block error" for test of looker enterprise #10365
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
|
mmv1/products/looker/Instance.yaml
Outdated
@@ -69,9 +69,9 @@ examples: | |||
client_id: 'my-client-id' | |||
client_secret: 'my-client-secret' | |||
test_vars_overrides: | |||
address_name: 'acctest.BootstrapSharedTestGlobalAddress(t, "looker-vpc-network-1", acctest.AddressWithPrefixLength(20))' | |||
address_name: 'acctest.BootstrapSharedTestGlobalAddress(t, "looker-vpc-network-1")' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need to change the name looker-vpc-network-1
to something else to test if this works, as based on how we set up the bootstrapped resource, they won't get recreated without the name changed (we'll read the resource first and only create a new one if no existing one is found)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shuyama1 Okay, done!
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccLookerInstance_lookerInstanceEnterpriseFullTestExample |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Set no prefix to fix IP range no free block error
Fixes hashicorp/terraform-provider-google#17394
Error to resolve:
Release Note Template for Downstream PRs (will be copied)