Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set no prefix to fix "IP range no free block error" for test of looker enterprise #10365

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Set no prefix to fix "IP range no free block error" for test of looker enterprise #10365

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f9d1110
Update Instance.yaml
efeelaiho Apr 4, 2024
9fcd83d
Merge branch 'GoogleCloudPlatform:main' into fix-look-ent
efeelaiho Apr 9, 2024
a541be1
Merge branch 'GoogleCloudPlatform:main' into fix-look-ent
efeelaiho Apr 10, 2024
cbc6867
Update Instance.yaml
efeelaiho Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mmv1/products/looker/Instance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ examples:
client_id: 'my-client-id'
client_secret: 'my-client-secret'
test_vars_overrides:
address_name: 'acctest.BootstrapSharedTestGlobalAddress(t, "looker-vpc-network-1", acctest.AddressWithPrefixLength(20))'
address_name: 'acctest.BootstrapSharedTestGlobalAddress(t, "looker-vpc-network-1")'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to change the name looker-vpc-network-1 to something else to test if this works, as based on how we set up the bootstrapped resource, they won't get recreated without the name changed (we'll read the resource first and only create a new one if no existing one is found)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shuyama1 Okay, done!

kms_key_name: 'acctest.BootstrapKMSKeyInLocation(t, "us-central1").CryptoKey.Name'
network_name: 'acctest.BootstrapSharedServiceNetworkingConnection(t, "looker-vpc-network-1", acctest.ServiceNetworkWithPrefixLength(20))'
network_name: 'acctest.BootstrapSharedServiceNetworkingConnection(t, "looker-vpc-network-1")'
skip_docs: true
- !ruby/object:Provider::Terraform::Examples
name: 'looker_instance_custom_domain'
Expand Down
Loading