feat: add labels validations

[EladLeev]

Hey 👋
A quick PR to add some labels validations based on the documentation.
The problem this PR is trying to solve is that nothing validates that the labels are correct before the apply phase which gets an error from the API.

Release Note Template for Downstream PRs (will be copied)

storage: added labels validation to 'google_storage_bucket' resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[rileykarson]

@zli82016 do you mind taking this review? Would this conflict with the customizediff at all?

[zli82016]

@zli82016 do you mind taking this review? Would this conflict with the customizediff at all?

I will take this review.

[zli82016]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 21 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 1 file changed, 21 insertions(+), 4 deletions(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[zli82016]

I run tests locally. ValidateFunc and CustomizeDiff don't conflict. ValidateFunc is called before CustomizeDiff

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• storage

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log

[zli82016]

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
Errors occurred during RECORDING mode. Please fix them to complete your PR. View the build log

@EladLeev , can you please fix the build error? Thanks.

# github.com/hashicorp/terraform-provider-google-beta/google-beta/services/storage [github.com/hashicorp/terraform-provider-google-beta/google-beta/services/storage.test]
google-beta/services/storage/resource_storage_bucket.go:523:21: undefined: regexp

[EladLeev]

That's embarrassing 🤦 haha, sorry for that.
I've updated the branch - can you please check again?

[zli82016]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 22 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 1 file changed, 22 insertions(+), 4 deletions(-))

[modular-magician]

Tests analytics

Total tests: 91
Passed tests: 85
Skipped tests: 6
Affected tests: 0

Click here to see the affected service packages

• storage

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

[zli82016]

@EladLeev , is there a Github issue or buganizer issue for this PR? If yes, can you please add it to the description section of this PR with the format fixes xxxx?

[EladLeev]

Not really tbh. I can search the open issues to see if someone mentioned it, but it's something I'm facing from time to time (with many providers) and might give a better DevEx to users

[zli82016]

Thanks, LGTM.