Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to address ambiguity in error message. #10389

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

spapi17
Copy link
Contributor

@spapi17 spapi17 commented Apr 8, 2024

Release Note Template for Downstream PRs (will be copied)

composer: fixed validation on `google_composer_environment` resource so it will identify a disallowed upgrade to Composer 3 before attempting to provide feedback that's specific to using Composer 3

@spapi17 spapi17 changed the title stop validation in case of upgrade attempt Minor fix to address ambiguity in error message. Apr 8, 2024
@spapi17 spapi17 marked this pull request as ready for review April 8, 2024 16:32
Copy link

github-actions bot commented Apr 8, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 42
Passed tests: 42
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • composer

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@spapi17
Copy link
Contributor Author

spapi17 commented Apr 10, 2024

Hi @SarahFrench, could you please take a look?

@SarahFrench SarahFrench merged commit dc3e088 into GoogleCloudPlatform:main Apr 10, 2024
14 of 15 checks passed
simalcubuk pushed a commit to simalcubuk/magic-modules that referenced this pull request Apr 11, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
@spapi17 spapi17 deleted the fix-validation branch June 20, 2024 11:04
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants