-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowed modifying request headers via pre_create, pre_read, pre_update, or pre_delete custom code #10405
Conversation
…delete custom code
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccFolderIamPolicy_basic|TestAccSqlUser_postgresIAM |
|
@c2thorn this should be ready for review now; the failing test is unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nil check seems to cover all cases
FYI @NickElliot some lines added to resource.erb here, so we could close out a bug in time |
…e, or pre_delete custom code (GoogleCloudPlatform#10405)
…e, or pre_delete custom code (GoogleCloudPlatform#10405)
…e, or pre_delete custom code (GoogleCloudPlatform#10405)
…e, or pre_delete custom code (GoogleCloudPlatform#10405)
…e, or pre_delete custom code (GoogleCloudPlatform#10405)
…e, or pre_delete custom code (GoogleCloudPlatform#10405)
…e, or pre_delete custom code (GoogleCloudPlatform#10405)
…e, or pre_delete custom code (GoogleCloudPlatform#10405)
Resolved hashicorp/terraform-provider-google#16331.
The specific resource issue this was blocking (hashicorp/terraform-provider-google#15550) was resolved separately so no changes are needed there.
Given we don't have a clear idea of what features we might need to support in the future, and this does not currently seem to be a common use case, I don't want to implement any kind of special MM field at this time; however, this change would be necessary for any changes to MM fields in the future as well.
Release Note Template for Downstream PRs (will be copied)