Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed modifying request headers via pre_create, pre_read, pre_update, or pre_delete custom code #10405

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

melinath
Copy link
Member

@melinath melinath commented Apr 9, 2024

Resolved hashicorp/terraform-provider-google#16331.

The specific resource issue this was blocking (hashicorp/terraform-provider-google#15550) was resolved separately so no changes are needed there.

Given we don't have a clear idea of what features we might need to support in the future, and this does not currently seem to be a common use case, I don't want to implement any kind of special MM field at this time; however, this change would be necessary for any changes to MM fields in the future as well.

Release Note Template for Downstream PRs (will be copied)


@melinath melinath changed the title Allowed modifying request headers via pre_create, pre_update, or pre_delete custom code Allowed modifying request headers via pre_create, pre_read, pre_update, or pre_delete custom code Apr 9, 2024
@melinath melinath requested a review from c2thorn April 9, 2024 22:46
@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 400 files changed, 3808 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 458 files changed, 4354 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3569
Passed tests: 3199
Skipped tests: 368
Affected tests: 2

Click here to see the affected service packages
all service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFolderIamPolicy_basic|TestAccSqlUser_postgresIAM

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccFolderIamPolicy_basic[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSqlUser_postgresIAM[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@melinath
Copy link
Member Author

@c2thorn this should be ready for review now; the failing test is unrelated.

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nil check seems to cover all cases

@c2thorn
Copy link
Member

c2thorn commented Apr 11, 2024

FYI @NickElliot some lines added to resource.erb here, so we could close out a bug in time

balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support configurable HTTP header in magic module
3 participants