Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed color formatting for VCR test results #10681

Merged
merged 1 commit into from
May 13, 2024

Conversation

melinath
Copy link
Member

Also fixed an incorrect reference to RECORDING mode.

Example failure mode: #10664 (comment)

Release Note Template for Downstream PRs (will be copied)


Also fixed an incorrect reference to RECORDING mode
@melinath melinath requested review from a team and slevenick and removed request for a team May 13, 2024 16:33
@melinath melinath requested review from shuyama1 and removed request for slevenick May 13, 2024 16:35
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should also work!

@melinath melinath merged commit 6f0cea2 into GoogleCloudPlatform:main May 13, 2024
11 checks passed
@melinath melinath deleted the fix-color-formatting branch May 13, 2024 18:03
kautikdk pushed a commit to kautikdk/magic-modules that referenced this pull request May 16, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
ma-g-22 pushed a commit to ma-g-22/magic-modules that referenced this pull request May 21, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants