Add support for google_service_account_key to TGC
#10693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
the
awaiting-approval
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
/gcbrun |
modular-magician
removed
the
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
@shuyama1 cold you please reviewe this PR? |
shuyama1
approved these changes
May 15, 2024
kautikdk
pushed a commit
to kautikdk/magic-modules
that referenced
this pull request
May 16, 2024
pawelJas
pushed a commit
to pawelJas/magic-modules
that referenced
this pull request
May 16, 2024
avijain25
pushed a commit
to avijain25/magic-modules
that referenced
this pull request
May 21, 2024
ma-g-22
pushed a commit
to ma-g-22/magic-modules
that referenced
this pull request
May 21, 2024
pengq-google
pushed a commit
to pengq-google/magic-modules
that referenced
this pull request
May 21, 2024
Cheriit
pushed a commit
to Cheriit/magic-modules
that referenced
this pull request
Jun 4, 2024
pcostell
pushed a commit
to pcostell/magic-modules
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note Template for Downstream PRs (will be copied)