-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lb traffic extension resource #10121
Add lb traffic extension resource #10121
Conversation
…raffic-extension sync merge from pweiber/lb-traffic-extension
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could please remove the trailing white spaces on all files so it can pass lint? Then I'll start up running tests on it. Thanks!
Hey @NickElliot I am still waiting for the API to become GA in order to validate the tests PD: they told they are releasing it in the comming weeks |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 430 insertions(+)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_network_services_lb_traffic_extension" "primary" {
description = # value needed
extension_chains {
extensions {
fail_open = # value needed
forward_headers = # value needed
}
}
labels = # value needed
}
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These need to be updated, thanks!
location = "us-west1" | ||
name = "lb-traffic-extension" | ||
provider = google-beta | ||
forwarding_rules = ["https://www.googleapis.com/compute/v1/projects/myproj/regions/us-west1/forwardingRules/l7-ilb-forwarding-rule"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be an id reference to a forwarding rule created in this example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @NickElliot. API is returning the self_link using number, so I do not think we can use the id field here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the string could be constructed using variables such as
"https://www.googleapis.com/compute/v1/projects/<%= ctx[:test_env_vars]['project'] %>/regions/us-west1/forwardingRules/<%= ctx[:vars]['forwarding_rule_name'] %>"
extensions { | ||
name = "ext11" | ||
authority = "ext11.com" | ||
service = "https://www.googleapis.com/compute/v1/projects/myproj/regions/us-west1/backendServices/l7-ilb-test-vm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here but for backend service!
sync merge from upstream/main
sync merge upstream/main
sync merge from upstream/main
/gcbrun |
Hello @NickElliot, still working on adding integration tests but I should be able to push some of them today for traffic and route extensions |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_network_services_lb_traffic_extension" "primary" {
description = # value needed
extension_chains {
extensions {
fail_open = # value needed
forward_headers = # value needed
}
}
labels = # value needed
}
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample |
|
sync merge from upstream/main
All good, ping me when you have them ready @maxi-cit |
Also in case it resolves the current VCR error, could you rebase? Thanks! |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
|
sync merge from upstream/main
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: pweiber <[email protected]>
Co-authored-by: pweiber <[email protected]>
Co-authored-by: pweiber <[email protected]>
Co-authored-by: pweiber <[email protected]>
Co-authored-by: pweiber <[email protected]>
Co-authored-by: pweiber <[email protected]>
Adds the new google_network_services_lb_traffic_extension resource.
Part of: hashicorp/terraform-provider-google#17491
Fixes: hashicorp/terraform-provider-google#17373
Release Note Template for Downstream PRs (will be copied)