-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lb route extension resource #10119
Add lb route extension resource #10119
Conversation
…te-extension sync merge from pweiber/lb-route-extension
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Can you please fix the yaml lint errors? Thanks. |
working on it |
Hey @zli82016, I am still waiting for the API to become GA in order to validate the tests PD: they told they are releasing it in the comming weeks |
Thanks for letting me know. |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 429 insertions(+)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_network_services_lb_route_extension" "primary" {
description = # value needed
extension_chains {
extensions {
fail_open = # value needed
forward_headers = # value needed
supported_events = # value needed
}
}
labels = # value needed
}
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample |
|
sync merge upstream/main
Can you also add the update tests for the fields that can be updated in-place? This is the doc how to add an update test. Thanks. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_network_services_lb_route_extension" "primary" {
description = # value needed
extension_chains {
extensions {
forward_headers = # value needed
supported_events = # value needed
}
}
labels = # value needed
project = # value needed
}
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample |
|
Hello @zli82016, I added your suggestions and I think I am ready for another round of reviews. Could you run the tests please? |
This PR has been waiting for review for 2 days. Please take a look! Use the label |
Hello @zli82016, any issues with the tests? |
I just approved the test trigger. Let's see how it is going. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccNetworkServicesLbRouteExtension_update|TestAccNetworkServicesLbTrafficExtension_update |
|
I updated the release notes to reflect all of the changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking change should be removed from this PR.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Co-authored-by: pweiber <[email protected]>
Co-authored-by: pweiber <[email protected]>
Co-authored-by: pweiber <[email protected]>
Co-authored-by: pweiber <[email protected]>
Co-authored-by: pweiber <[email protected]>
Adds the new google_network_services_lb_route_extension resource.
Part of: hashicorp/terraform-provider-google#17491
Fixes: hashicorp/terraform-provider-google#17372
Release Note Template for Downstream PRs (will be copied)