Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lb route extension resource #10119

Merged
merged 16 commits into from
May 20, 2024

Conversation

maxi-cit
Copy link
Contributor

@maxi-cit maxi-cit commented Mar 5, 2024

Adds the new google_network_services_lb_route_extension resource.

Part of: hashicorp/terraform-provider-google#17491
Fixes: hashicorp/terraform-provider-google#17372

Release Note Template for Downstream PRs (will be copied)

`google_network_services_lb_route_extension`
networkservices: made required fields `extension_chains.extensions.authority ` and `extension_chains.extensions.timeout` optional in resource `google_network_services_lb_traffic_extension`
networkservices: made field `load_balancing_scheme` immutable in resource `google_network_services_lb_traffic_extension`, as in-place updating is always failing
networkservices: removed unsupported load balancing scheme `LOAD_BALANCING_SCHEME_UNSPECIFIED` from the field `load_balancing_scheme` in resource `google_network_services_lb_traffic_extension`

@github-actions github-actions bot requested a review from zli82016 March 5, 2024 15:18
Copy link

github-actions bot commented Mar 5, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@zli82016
Copy link
Member

zli82016 commented Mar 5, 2024

Can you please fix the yaml lint errors? Thanks.

@maxi-cit
Copy link
Contributor Author

maxi-cit commented Mar 5, 2024

working on it

@maxi-cit
Copy link
Contributor Author

maxi-cit commented Mar 7, 2024

Hey @zli82016, I am still waiting for the API to become GA in order to validate the tests

PD: they told they are releasing it in the comming weeks

@zli82016
Copy link
Member

zli82016 commented Mar 7, 2024

Hey @zli82016, I am still waiting for the API to become GA in order to validate the tests

PD: they told they are releasing it in the comming weeks

Thanks for letting me know.

@zli82016
Copy link
Member

zli82016 commented Mar 7, 2024

/gcbrun

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 7, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 429 insertions(+))
Terraform Beta: Diff ( 5 files changed, 1766 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 267 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_lb_route_extension (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_lb_route_extension" "primary" {
  description = # value needed
  extension_chains {
    extensions {
      fail_open        = # value needed
      forward_headers  = # value needed
      supported_events = # value needed
    }
  }
  labels = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 47
Passed tests: 46
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 30, 2024
@zli82016
Copy link
Member

zli82016 commented May 1, 2024

Can you also add the update tests for the fields that can be updated in-place? This is the doc how to add an update test. Thanks.

@github-actions github-actions bot requested a review from zli82016 May 2, 2024 08:16
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 2, 2024
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 2, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 544 insertions(+))
google-beta provider: Diff ( 5 files changed, 2010 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 267 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_lb_route_extension (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_lb_route_extension" "primary" {
  description = # value needed
  extension_chains {
    extensions {
      forward_headers  = # value needed
      supported_events = # value needed
    }
  }
  labels  = # value needed
  project = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 47
Passed tests: 46
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

mmv1/products/networkservices/LbRouteExtension.yaml Outdated Show resolved Hide resolved
mmv1/products/networkservices/LbRouteExtension.yaml Outdated Show resolved Hide resolved
mmv1/products/networkservices/LbRouteExtension.yaml Outdated Show resolved Hide resolved
mmv1/products/networkservices/LbRouteExtension.yaml Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a review from zli82016 May 18, 2024 11:25
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 18, 2024
@maxi-cit
Copy link
Contributor Author

Hello @zli82016, I added your suggestions and I think I am ready for another round of reviews. Could you run the tests please?

Copy link

This PR has been waiting for review for 2 days. Please take a look! Use the label disable-review-reminders to disable these notifications.

@maxi-cit
Copy link
Contributor Author

Hello @zli82016, any issues with the tests?

@zli82016
Copy link
Member

Hello @zli82016, any issues with the tests?

I just approved the test trigger. Let's see how it is going.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 20, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 2910 insertions(+), 38 deletions(-))
google-beta provider: Diff ( 8 files changed, 2910 insertions(+), 38 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 256 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 449 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field load_balancing_scheme changed from optional to required on google_network_services_lb_traffic_extension - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 51
Passed tests: 49
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • networkservices

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkServicesLbRouteExtension_update|TestAccNetworkServicesLbTrafficExtension_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetworkServicesLbRouteExtension_update[Debug log]
TestAccNetworkServicesLbTrafficExtension_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@zli82016
Copy link
Member

I updated the release notes to reflect all of the changes in this PR.

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change should be removed from this PR.

@github-actions github-actions bot requested a review from zli82016 May 20, 2024 18:44
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels May 20, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 2901 insertions(+), 29 deletions(-))
google-beta provider: Diff ( 8 files changed, 2901 insertions(+), 29 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 256 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 449 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 51
Passed tests: 51
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • networkservices

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@zli82016 zli82016 merged commit 0650b2f into GoogleCloudPlatform:main May 20, 2024
14 checks passed
avijain25 pushed a commit to avijain25/magic-modules that referenced this pull request May 21, 2024
ma-g-22 pushed a commit to ma-g-22/magic-modules that referenced this pull request May 21, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send "google_network_services_lb_route_extension" to G.A
4 participants