-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote google_cloud_asset_resources_search_all datasource to ga #10660
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Non-exercised testsTests were added that are GA-only additions and require manual runs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any guarantee that, other than additional_attributes
, the GA API here is a superset of the beta one? We may want to add a separate resource if there aren't, data.google_cloud_asset_search_all_resources
.
The tests for a datasource are definitely not complete enough to assert as much.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Non-exercised testsTests were added that are skipped in VCR:
|
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Non-exercised testsTests were added that are skipped in VCR:
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccCloudFunctionsFunction_firestore|TestAccDataSourceGoogleCloudAssetSearchAllResources_basic |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccCloudFunctionsFunction_firestore|TestAccDataprocClusterIamPolicy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, waiting on test results.
|
Promote google_cloud_asset_resources_search_all datasource to ga
hashicorp/terraform-provider-google#18034
Note: CloudAsset V1 API: resourcesSearchAll has multiple
dynamicType
fields, which is currently impossible to handle well in the provider. All suth fields and some useless are avoided in the datasource, includingadditional_attributes
field. We still keepadditional_attributes
field in thebeta
datasource, since beta API has a fixed type for the field.Release Note Template for Downstream PRs (will be copied)