Add support for Vmwareengine Stretch Private Clouds.

[swamitagupta]

Vmwareengine Private Clouds(PC) have a zonal scope. A Stretch Private Cloud is a resource which can be stretched over 2 zones and has a regional scope. This PR adds the terraform support to create a stretch PC.

Please note that currently stretch private clouds need at least 6 nodes (for context, a majority of current vmareengine resource tests use a 1 node PC). Further, it is currently only supported in 3 regions, and all of them are full with customer nodes. Hence, it would not be possible to nightly run stretch PC tests on Terraform.

Release Note Template for Downstream PRs (will be copied)

vmwareengine: added support for stretch private clouds

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 67 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 67 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vmwareengine_private_cloud (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vmwareengine_private_cloud" "primary" {
  preferred_zone = # value needed
  secondary_zone = # value needed
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 67 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 67 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vmwareengine_private_cloud (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vmwareengine_private_cloud" "primary" {
  preferred_zone = # value needed
  secondary_zone = # value needed
}

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 14
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

• vmwareengine

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

[roaks3]

/gcbrun

[roaks3]

/gcbrun

[roaks3]

@swamitagupta could you try rebasing this PR to pull in the latest from main? There seems to be something wrong with the merge base, and we've made a number of changes on our side that could have gotten things into a weird state.

[swamitagupta]

@swamitagupta could you try rebasing this PR to pull in the latest from main? There seems to be something wrong with the merge base, and we've made a number of changes on our side that could have gotten things into a weird state.

Done :)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 67 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 67 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vmwareengine_private_cloud (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vmwareengine_private_cloud" "primary" {
  preferred_zone = # value needed
  secondary_zone = # value needed
}

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 14
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

• vmwareengine

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log