Add support for Vmwareengine Stretch Private Clouds. #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:d4184550975bcc25e7e1402835a198698c7f2deb] Signed-off-by: Modular Magician <[email protected]>
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
merged commit 9d23d8d
into
GoogleCloudPlatform:main
5 of 6 checks passed
modular-magician
deleted the
downstream-pr-d4184550975bcc25e7e1402835a198698c7f2deb
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vmwareengine Private Clouds(PC) have a zonal scope. A Stretch Private Cloud is a resource which can be stretched over 2 zones and has a regional scope. This PR adds the terraform support to create a stretch PC.
Please note that currently stretch private clouds need at least 6 nodes (for context, a majority of current vmareengine resource tests use a 1 node PC). Further, it is currently only supported in 3 regions, and all of them are full with customer nodes. Hence, it would not be possible to nightly run stretch PC tests on Terraform.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#10340