Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Adding self_link output to google_network_security profile group" #10696

Merged

Conversation

LucaPrete
Copy link
Member

@LucaPrete LucaPrete commented May 14, 2024

Reverts #10654

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 15 deletions(-))
google-beta provider: Diff ( 2 files changed, 15 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field self_link within resource google_network_security_security_profile_group was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 37
Passed tests: 36
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • networksecurity

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@c2thorn c2thorn added the override-breaking-change Allows a potential breaking change to be merged label May 14, 2024
@c2thorn c2thorn merged commit 1895c01 into GoogleCloudPlatform:main May 14, 2024
12 of 14 checks passed
kautikdk pushed a commit to kautikdk/magic-modules that referenced this pull request May 16, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
ma-g-22 pushed a commit to ma-g-22/magic-modules that referenced this pull request May 21, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants