-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7.0 Deployment #3224
7.0 Deployment #3224
Conversation
…d add IsNull method for Borehole
Co-authored-by: Fraser Greenroyd <[email protected]>
Co-authored-by: Fraser Greenroyd <[email protected]>
…space containment check
Co-authored-by: Fraser Greenroyd <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have run the test scripts and happy to approve for:
- Ground_Engine
- Physical_Engine
- Structure_Engine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for Diffing_Engine and base BHoM_Engine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing using the Lighting_Engine testing procedure. Passed.
Testing using the Facades_Engine testing procedure. Passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested for Lighting_Engine, passed per testing procedure for engine methods and results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on S&P 7.0 testing report
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 25 requests in the queue ahead of you. |
Please be advised that the check with reference 19832638962 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 18 additional annotations waiting, made up of 0 errors and 18 warnings. |
@bhombot-ci[bot] just to let you know, I have provided a |
@bhombot-ci[bot] just to let you know, I have provided a |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 9 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PRs have been reviewed by DevOps and are suitable for the deployment of develop
to the 7.0 beta. Approving for merge.
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@bhombot-ci[bot] just to let you know, I have provided a |
BHoM_Engine
Feature
Create
methods andIsValid
methods forBorehole
,Stratum
andContaminantSample
objectsQuery
method to retrieveStratum
lines that are useful for visualisationCreate
methods forPadFoundation
andPileFoundation
objects;Pile
create method and ammendedCreate
method;IsNull
methods forPile
,PadFoundation
,PileFoundation
,IFramingElementProperty
andIConstruction
IElement1D
methods forPile
includingGeometry()
(other methods covered byIFramingElement
inheritance;IElement2D
methods forPadFoundation
includingOutlineElements1D
,SetOutlineElements1D
andHasMegeableProprties()
IElementM
methods forPadFoundation
,Pile
andPileFoundation
includingSolidVolume
,MaterialComposition
andHasMergeableProperties
;IsWithinPileCap
method to check whether thePile.Location
top exists within the 3D geometry of thePadFoundation
;EmbedVolume
that calculates the volume of thePile
that is embed within thePadFoundation
when aPileFoundation
is used this method is utilised withinSolidVolume()
.PadFoundation
andPileFoundation
to work withIElement2D
andIElementM
respectively;Create
methods forPadFoundation
,PileFoundation
andPileGroup
IsNull
methods to include new foundation objects;GrahamScan
method to determine the perimeter of aList<Point>
which is used in theCreate
methods for aPileFoundation
.Bug
Poyline
was returning morePoint
s than were being input.FromJson()
to Trim the text before attempting to read itCompliance
Test-script
Documentation
User-experience