Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.0 Deployment #3224

Merged
merged 130 commits into from
Dec 20, 2023
Merged

7.0 Deployment #3224

merged 130 commits into from
Dec 20, 2023

Conversation

bhombot-ci[bot]
Copy link

@bhombot-ci bhombot-ci bot commented Dec 11, 2023

BHoM_Engine

Feature

Bug

Compliance

Test-script

Documentation

User-experience

BHoMBot and others added 30 commits September 25, 2023 14:31
@FraserGreenroyd FraserGreenroyd added type:compliance Non-conforming to code guidelines type:feature New capability or enhancement and removed type:compliance Non-conforming to code guidelines labels Dec 11, 2023
@peterjamesnugent peterjamesnugent self-requested a review December 13, 2023 11:12
Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have run the test scripts and happy to approve for:

  • Ground_Engine
  • Physical_Engine
  • Structure_Engine

Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for Diffing_Engine and base BHoM_Engine

@JohnSloane JohnSloane self-requested a review December 17, 2023 21:42
Copy link

@JohnSloane JohnSloane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing using the Lighting_Engine testing procedure. Passed.

@gideontamir16 gideontamir16 self-requested a review December 18, 2023 15:51
@gideontamir16
Copy link

Testing using the Facades_Engine testing procedure. Passed.

@enarhi enarhi self-requested a review December 20, 2023 01:15
Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for Lighting_Engine, passed per testing procedure for engine methods and results.

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on S&P 7.0 testing report

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 25 requests in the queue ahead of you.

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

Please be advised that the check with reference 19832638962 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 18 additional annotations waiting, made up of 0 errors and 18 warnings.

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Versioning_Toolkit

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check null-handling
@BHoMBot check serialisation

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation

There are 9 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs have been reviewed by DevOps and are suitable for the deployment of develop to the 7.0 beta. Approving for merge.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd FraserGreenroyd merged commit d13f40b into main Dec 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.