Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHoM_Engine_Tests: Align with Test_Toolkit changes #3015

Merged
merged 10 commits into from
Aug 24, 2023

Conversation

alelom
Copy link
Member

@alelom alelom commented Mar 9, 2023

NOTE: Depends on

BHoM/Test_Toolkit#422 (already merged)
BHoM/Test_Toolkit#445 (already merged)

Issues addressed by this PR

Closes #3014
Closes #3059

Existing unit test now have their class inheriting from the Test_Toolkit NUnitTest abstract class, which provides them with dynamic assembly loading and reporting of event log into the results of the test.

Additionally, a new Structure_Engine_Test project was added with a specific test on a method that requires dynamic assembly loading in order to work (it uses an extension method). This was added mainly to verify that the functionality added via the NUnitTest class works, but it is also a useful test in itself which justifies keeping it in. @FraserGreenroyd

Test files

Unit tests must all pass, both from Test Explorer in Visual Studio and from an NUnit TestRunner environment (BHoMBot).

Changelog

Additional comments

@alelom alelom self-assigned this Mar 9, 2023
@alelom alelom added the type:compliance Non-conforming to code guidelines label Mar 9, 2023
@alelom alelom requested a review from FraserGreenroyd March 9, 2023 09:48
@alelom
Copy link
Member Author

alelom commented Mar 10, 2023

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2023

@alelom to confirm, the following actions are now queued:

  • check unit-tests

@alelom alelom added the type:test-script Creation of unit test required label Mar 15, 2023
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 13, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting force checks on: unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 13, 2023

@FraserGreenroyd I am now running force checks on the checks requested. These will be queued and actioned ASAP.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 13, 2023

@FraserGreenroyd I have provided force checks to the checks requested.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting force checks on: unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 13, 2023

@FraserGreenroyd I am now running force checks on the checks requested. These will be queued and actioned ASAP.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 13, 2023

@FraserGreenroyd I have provided force checks to the checks requested.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting force checks on: unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 13, 2023

@FraserGreenroyd I am now running force checks on the checks requested. These will be queued and actioned ASAP.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 25, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 25, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 25, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 25, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting force checks on: unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 25, 2023

@FraserGreenroyd I am now running force checks on the checks requested. These will be queued and actioned ASAP.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 25, 2023

@FraserGreenroyd I have provided force checks to the checks requested.

@FraserGreenroyd FraserGreenroyd force-pushed the BHoM_Engine_Tests-#3014-AlignWithTest_Toolkit branch from 084f9aa to fa20e68 Compare August 24, 2023 15:44
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 24, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

There are 19 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@alelom I see no more reason to hold up this PR so I'm going to go for merge - the failures are from Data Driven unit tests, and we've previously tested this heavily - so I think we're good to go for merging this one and continuing developments of tests.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 24, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 34 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@alelom I've removed that this PR takes care of #3018 because this PR isn't doing that anymore so we'll need to tackle #3018 later 😄

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 24, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check project-compliance

There are 2 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 24, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance

There are 2 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 24, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check project-compliance

There are 1 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, unit-tests, serialisation, ready-to-merge, null-handling, installer, documentation-compliance, dataset-compliance, core, code-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 24, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed over time with @alelom - some things to resolve later but this PR is in a good enough state to close out and merge in for future testing work.

@FraserGreenroyd FraserGreenroyd removed the type:compliance Non-conforming to code guidelines label Aug 24, 2023
@FraserGreenroyd FraserGreenroyd merged commit e8c9fe3 into develop Aug 24, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine_Tests-#3014-AlignWithTest_Toolkit branch August 24, 2023 16:31
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:test-script Creation of unit test required
Projects
None yet
2 participants