-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BHoM_Engine_Tests: Align with Test_Toolkit changes #3015
BHoM_Engine_Tests: Align with Test_Toolkit changes #3015
Conversation
@BHoMBot check unit-tests |
@alelom to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot this is a DevOps instruction. I am requesting force checks on: unit-tests |
@FraserGreenroyd I am now running force checks on the checks requested. These will be queued and actioned ASAP. |
@FraserGreenroyd I have provided force checks to the checks requested. |
@BHoMBot this is a DevOps instruction. I am requesting force checks on: unit-tests |
@FraserGreenroyd I am now running force checks on the checks requested. These will be queued and actioned ASAP. |
@FraserGreenroyd I have provided force checks to the checks requested. |
@BHoMBot this is a DevOps instruction. I am requesting force checks on: unit-tests |
@FraserGreenroyd I am now running force checks on the checks requested. These will be queued and actioned ASAP. |
@BHoMBot check unit-tests |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot this is a DevOps instruction. I am requesting force checks on: unit-tests |
@FraserGreenroyd I am now running force checks on the checks requested. These will be queued and actioned ASAP. |
@FraserGreenroyd I have provided force checks to the checks requested. |
084f9aa
to
fa20e68
Compare
@BHoMBot check unit-tests |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 19 requests in the queue ahead of you. |
@alelom I see no more reason to hold up this PR so I'm going to go for merge - the failures are from Data Driven unit tests, and we've previously tested this heavily - so I think we're good to go for merging this one and continuing developments of tests. |
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 34 requests in the queue ahead of you. |
@BHoMBot check project-compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
@BHoMBot check copyright-compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, unit-tests, serialisation, ready-to-merge, null-handling, installer, documentation-compliance, dataset-compliance, core, code-compliance |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed over time with @alelom - some things to resolve later but this PR is in a good enough state to close out and merge in for future testing work.
NOTE: Depends on
BHoM/Test_Toolkit#422 (already merged)
BHoM/Test_Toolkit#445 (already merged)
Issues addressed by this PR
Closes #3014
Closes #3059
Existing unit test now have their class inheriting from the Test_Toolkit
NUnitTest
abstract class, which provides them with dynamic assembly loading and reporting of event log into the results of the test.Additionally, a new Structure_Engine_Test project was added with a specific test on a method that requires dynamic assembly loading in order to work (it uses an extension method). This was added mainly to verify that the functionality added via the
NUnitTest
class works, but it is also a useful test in itself which justifies keeping it in. @FraserGreenroydTest files
Unit tests must all pass, both from Test Explorer in Visual Studio and from an NUnit TestRunner environment (BHoMBot).
Changelog
Additional comments