Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added base NUnitTest class with LoadAssembly and Note reporting functionality #422

Merged
merged 41 commits into from
Mar 8, 2023

Conversation

alelom
Copy link
Member

@alelom alelom commented Feb 24, 2023

Issues addressed by this PR

Closes #420
This also lays the foundation for #421, however the resolution of #421 requires some refactoring as the required information to be plotted is stored in testResult.InnerXml (as opposed to the currently used testResult.OuterXml). This means we need to change the Convert methods. Will be targeted by separate issue/PR.

Test files

See .ci/unit-test. All tests must pass.
Note that the .ci folder contains 3 separate testing projects, as required to appropriately test the added functionality.

@alelom alelom self-assigned this Feb 24, 2023
@alelom alelom added the type:feature New capability or enhancement label Feb 24, 2023
@alelom alelom marked this pull request as draft February 27, 2023 17:13
@alelom alelom force-pushed the Test_Toolkit-#420-#421-ImprovedNUnitManagement branch from 0b39f9e to 4de4823 Compare March 2, 2023 15:43
alelom added 3 commits March 8, 2023 12:41
For clarity. This test project has two types of tests:
- Tests against incorrectly referenced assemblies (e.g. wrong copy local)
- Tests against test methods that depend on assemblies to be dynamically loaded, but are not referenced in the Test project.
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 8, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 8, 2023

@FraserGreenroyd fix requested for copyright headers.

The errors with the copyright headers on the CS (.cs) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

Each CS (.cs) file that does not have the current copyright header will have it applied. The current copyright header can be examined here.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix copyright headers ref. 11853368994

@FraserGreenroyd
Copy link
Contributor

@BHoMBot fix copyright headers ref. 11853368994

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 8, 2023

@FraserGreenroyd I have queued up your request to fix copyright headers. There are 0 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 8, 2023

@FraserGreenroyd I am now going to fix the copyright compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 8, 2023

@FraserGreenroyd to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 8, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check null-handling

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 8, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 8, 2023

@FraserGreenroyd fix requested for copyright headers.

The errors with the copyright headers on the CS (.cs) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

Each CS (.cs) file that does not have the current copyright header will have it applied. The current copyright header can be examined here.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix copyright headers ref. 11853831998

@FraserGreenroyd
Copy link
Contributor

@BHoMBot fix copyright headers ref. 11853831998

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 8, 2023

@FraserGreenroyd I have queued up your request to fix copyright headers. There are 0 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 8, 2023

@FraserGreenroyd I am now going to fix the copyright compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 8, 2023

@FraserGreenroyd to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check project-compliance
@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 8, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check project-compliance
  • check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 8, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is project-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 11854079970

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 11854079970

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 8, 2023

@FraserGreenroyd I have now provided a passing check on reference 11854079970 as requested.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A long task with @alelom but finally working after yesterday's sessions and tidied up for deployment, thanks @alelom

@FraserGreenroyd FraserGreenroyd merged commit c33c774 into main Mar 8, 2023
@FraserGreenroyd FraserGreenroyd deleted the Test_Toolkit-#420-#421-ImprovedNUnitManagement branch March 8, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create NUnitTest abstract class to expose NUnit related functionality
3 participants