Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NUnitTest_Engine: do not attempt to load assemblies from project reference when the context is the ProgramData BHoM folder #445

Merged
merged 1 commit into from
May 23, 2023
Merged

NUnitTest_Engine: do not attempt to load assemblies from project reference when the context is the ProgramData BHoM folder #445

merged 1 commit into from
May 23, 2023

Conversation

alelom
Copy link
Member

@alelom alelom commented May 23, 2023 •
edited
Loading

Issues addressed by this PR

Closes #444

Test files

Test via BHoMBot.

Changelog

The LoadReferencedAssemblies() method just returns when invoked via BHoMBot.

@alelom
NUnitTest_Engine: do not attempt to load assemblies from project refe…
2beef30 
…rence when the context is the ProgramData BHoM folder
@alelom alelom added the type:bug Error or unexpected behaviour label May 23, 2023
@alelom alelom self-assigned this May 23, 2023
@alelom alelom requested a review from FraserGreenroyd as a code owner May 23, 2023 15:02
FraserGreenroyd
FraserGreenroyd approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what's needed following debugging through on the bot with @alelom so happy to deploy

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check null-handling
@BHoMBot check project-compliance
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented May 23, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check null-handling
  • check project-compliance
  • check serialisation

@FraserGreenroyd FraserGreenroyd merged commit 144a20d into main May 23, 2023
@FraserGreenroyd FraserGreenroyd deleted the Test_Engine-#444-bhomBotCopyDlls branch May 23, 2023 15:06
@FraserGreenroyd FraserGreenroyd mentioned this pull request May 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

Assignees

@alelom alelom

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
2 participants
@alelom @FraserGreenroyd