Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment_Engine: Control of duplicate control points before extruding to volume #3186

Conversation

albinber
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #3185

Test files

Changelog

Additional comments

@albinber albinber added the type:user-experience Issues and changes relating to improving the overall User Experience (UX) of the tools label Sep 15, 2023
@albinber albinber self-assigned this Sep 15, 2023
@albinber
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 15, 2023

@albinber to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@albinber
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 15, 2023

@albinber to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 15, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 15, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 24 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 15, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 15, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 15, 2023

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, installer, ready-to-merge, unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 15, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, great work @albinber and good discussion with @charliebrookerBH on working out the UX on this 😄

@FraserGreenroyd FraserGreenroyd merged commit 8bc4a7b into develop Sep 15, 2023
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-#3185-PreventingExtrudingWithZeroArea branch September 15, 2023 16:22
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:user-experience Issues and changes relating to improving the overall User Experience (UX) of the tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment_Engine: Prevent ExtrudeToVolume extruding panels with no area
2 participants