Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment_Engine: Update PanelsContainingPoint to also return the panels not containing the point #3157

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #3156

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Aug 28, 2023
@FraserGreenroyd FraserGreenroyd requested a review from tg359 as a code owner August 28, 2023 15:48
@FraserGreenroyd FraserGreenroyd self-assigned this Aug 28, 2023
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check installer
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer
  • check core
  • check null-handling
  • check serialisation

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested through and works as expected

@FraserGreenroyd
Copy link
Contributor Author

FraserGreenroyd commented Aug 30, 2023

@BHoMBot check ready-to-merge

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 30, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 2 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 30, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit f301ec1 into develop Aug 30, 2023
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-#3156-PanelFilter branch August 30, 2023 16:02
@bhombot-ci
Copy link

bhombot-ci bot commented Aug 30, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 2 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 30, 2023

The check ready-to-merge has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment_Engine: Panels containing point to return panels not containing the point
2 participants