-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialiser_Engine: Deserialisation of nested lists #3160
Serialiser_Engine: Deserialisation of nested lists #3160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this makes sense.
I would have loved to be able to extract the type of object that are inside the list but this is is a bit trickier when dealing with json so happy with the current solution for now.
Just a minor tweak inside the DeserialiseNestedList
method and then I think we are good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy with the corrections following comments.
All works well now and code makes sense,
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check required |
@FraserGreenroyd to confirm, the following actions are now queued:
|
The check |
The check |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
Fixes #2674
Test Files
Available here. The JSON used has come from @tg359 on the linked issue which this PR aims to resolve.
On alpha:
On this PR:
If testing using the provided test script please make sure you redrag the output of
FromJson
into theExplode
component to get it to update. Alternatively, drop a newExplode
component on the canvas and compare the cached one with the one from this PR.E.G: