Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings_Engine: Fix output path #3163

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #3162

@FraserGreenroyd FraserGreenroyd added the type:bug Error or unexpected behaviour label Aug 29, 2023
@FraserGreenroyd FraserGreenroyd requested a review from enarhi August 29, 2023 19:43
@FraserGreenroyd FraserGreenroyd self-assigned this Aug 29, 2023
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core

Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as per visual inspection.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: installer, null-handling, ready-to-merge, serialisation, unit-tests, versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 1aacf75 into develop Aug 29, 2023
@FraserGreenroyd FraserGreenroyd deleted the Settings_Engine-#3162-OutputPath branch August 29, 2023 19:46
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings_Engine: Output not set to ..\Build\
2 participants