Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.ci Unit Tests - fix compilation #3159

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #3158

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Aug 29, 2023
@FraserGreenroyd FraserGreenroyd requested a review from alelom August 29, 2023 14:08
@FraserGreenroyd FraserGreenroyd self-assigned this Aug 29, 2023
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solution now compiles, but Test Explorer is unable to run the tests. Approving this PR as its scope is limited to make the solution compilable again, but further action is needed in order to remedy #3161

@FraserGreenroyd
Copy link
Contributor Author

FraserGreenroyd commented Aug 29, 2023

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: code-compliance, copyright-compliance, core, dataset-compliance, documentation-compliance, installer, null-handling, project-compliance, ready-to-merge, serialisation, unit-tests, versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 79f589b into develop Aug 29, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#3158-Compile branch August 29, 2023 16:56
@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit Tests - compilation
2 participants