Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment_Engine: Removed SplitPanelByGeometry due to lack of use and confusing UX #3176

Merged

Conversation

albinber
Copy link
Contributor

@albinber albinber commented Sep 6, 2023

NOTE: Depends on

Issues addressed by this PR

Closes #3125

Test files

Changelog

Additional comments

@albinber albinber added the type:documentation Wiki, help or in code attributes label Sep 6, 2023
@albinber albinber self-assigned this Sep 6, 2023
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad @albinber as I gave you the versioning key offline! My poor typing getting in the way this morning 🤕

Environment_Engine/Versioning_63.json Outdated Show resolved Hide resolved
@albinber
Copy link
Contributor Author

albinber commented Sep 6, 2023

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

@albinber to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 16 requests in the queue ahead of you.

@albinber
Copy link
Contributor Author

albinber commented Sep 6, 2023

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

@albinber to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 8 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

The check branch-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check serialisation
@BHoMBot check null-handling
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check serialisation
  • check null-handling
  • check installer

There are 2 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

There are 16 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method deleted, versioning happy, good to go 😄

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 7 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 0d7d071 into develop Sep 6, 2023
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-#3125-RemovingSplitPanelByGeometry branch September 6, 2023 11:23
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Wiki, help or in code attributes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environemnt_Engine Removing or renaming SplitPanelByGeometry.cs
2 participants