Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security_Engine: Camera Field of View angle fix #3099

Merged

Conversation

michal-pekacki
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #3098

Corrected angle calculation for Camera Field of View.

Test files

Rhino and GH files

Changelog

Additional comments

@michal-pekacki michal-pekacki added the type:bug Error or unexpected behaviour label Jun 28, 2023
@michal-pekacki michal-pekacki self-assigned this Jun 28, 2023
@pawelbaran
Copy link
Member

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 28, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as expected

@pawelbaran
Copy link
Member

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check unit-tests
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 28, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check unit-tests
  • check ready-to-merge

There are 9 requests in the queue ahead of you.

@pawelbaran
Copy link
Member

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 28, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check unit-tests

@pawelbaran
Copy link
Member

@FraserGreenroyd looks like the unit test check is failing without reporting - would be nice if you could have a look at some point (but no big rush from what I reckon)

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 28, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14635662271

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14635662271

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 28, 2023

@FraserGreenroyd I have now provided a passing check on reference 14635662271 as requested.

@FraserGreenroyd FraserGreenroyd merged commit 4474e0b into develop Jun 28, 2023
@FraserGreenroyd FraserGreenroyd deleted the Security_Engine-#3098-CameraFieldOfViewAngleFix branch June 28, 2023 20:20
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security_Engine: Camera Field of View incorrect angle
3 participants