Geometry_Engine: Add shortest path algorithm

[albinber]

NOTE: Depends on

Issues addressed by this PR

Closes #2826

Test files

Changelog

Additional comments

[albinber]

@BHoMBot check compliance

[bhombot-ci]

@albinber to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

There are 22 requests in the queue ahead of you.

[bhombot-ci]

@albinber fix requested for copyright headers.

The errors with the copyright headers on the CS (.cs) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

Each CS (.cs) file that does not have the current copyright header will have it applied. The current copyright header can be examined here.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix copyright headers ref. 16412106428

[albinber]

@BHoMBot fix copyright headers ref. 16412106428

[bhombot-ci]

@albinber I have queued up your request to fix copyright headers. There are 0 requests in the queue ahead of you.

[bhombot-ci]

@albinber I am now going to fix the copyright compliance in accordance with the annotations previously made.

[bhombot-ci]

@albinber to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.

[albinber]

@BHoMBot check compliance

[bhombot-ci]

@albinber to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[FraserGreenroyd]

Welcome to BHoM @albinber - great to have you here! A great first pull request - some small changes to the code structure (my favourite, blank lines 😉 ) and where we put the null check to protect the while loop.

Otherwise, code structure looks good and in line with @jamesramsden-bh original issue/pseudo code and works well in Rhino so great job 😄

[FraserGreenroyd]

All looks good now, thanks @albinber - great work 😄

[albinber]

@BHoMBot check compliance
@BHoMBot check required

[bhombot-ci]

@albinber to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[pawelbaran]

Hi @albinber, glad to see more faces contributing! 🚀 🚀 🚀

Starting from apologies: I do not want to spoil the party but... are we sure we are OK with modifying (i.e. emptying) the input collection? That should not happen from what I reckon - can be fixed easily by calling the following in line 42:

List<Point> ringPoints = points.ToList();

Would also be good to add checks against points being null or empty as well. But besides that, good stuff, can't wait for more! 👍

[albinber]

@BHoMBot check compliance
@BHoMBot check required

[bhombot-ci]

@albinber to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

There are 33 requests in the queue ahead of you.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[FraserGreenroyd]

Changes make sense in line with comments, good to go.

[FraserGreenroyd]

@BHoMBot check ready-to-merge

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check ready-to-merge

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

[bhombot-ci]

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.