Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHoM_Engine: Add ParseEnum method for int value and add ignoreCase option for string conversion #3149

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #3119

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Aug 17, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Aug 17, 2023
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 17, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

Copy link

@EKAdebo EKAdebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this code and it works as expected. LGTM, LGTM!

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 17, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core
  • check null-handling
  • check serialisation
  • check installer

There are 31 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, unit-tests, ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 17, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 909c3fb into develop Aug 17, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#3119-ParseEnum branch August 17, 2023 16:54
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BHoM_Engine string to enum converter
2 participants