Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/takeover 1886 #2

Merged
merged 54 commits into from
Jul 7, 2022
Merged

Dev/takeover 1886 #2

merged 54 commits into from
Jul 7, 2022

Conversation

ValarDragon
Copy link

Closes: #XXX

What is the purpose of the change

Add a description of the overall background and high level changes that this PR introduces

(E.g.: This pull request improves documation of area A by adding ....

Brief Changelog

(for example:)

  • The metadata is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • Daemons retrieve the RPC data from the blob cache

Testing and Verifying

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added unit test that validates ...
  • Added integration tests for end-to-end deployment with ...
  • Extended integration test for ...
  • Manually verified the change by ...

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

xBalbinus and others added 30 commits June 27, 2022 08:34
@xBalbinus @p0mvn
Added section to Contributing.md detailing our desired pre-release co…
6511fcc 
…de auditing process (#1848)

* chain json schema added

* pre-release code-auditing process docs initialization

* prerelease binary creation tool added

* fixed a letter-typo in chain-schema

* linked to v10 upgrade boilerplate, small phrasing changes

* md linter ifxes

* Update CONTRIBUTING.md

Co-authored-by: Roman <[email protected]>

* Replaced gofmt section with just make-format

* Added resource for auto-formatting in Go

Co-authored-by: Roman <[email protected]>
@ValarDragon
Cleanup root folder (#1883)
59472d7
@xBalbinus
Update add-issue-pr-to-project.yml (#1891)
41a8524
@mattverse @p0mvn
Improve readability in x/tokenfactory test (#1876)
c31b9d2 
* WIP

* finalize

* Add dev code review

* Update x/tokenfactory/keeper/admins_test.go

Co-authored-by: Roman <[email protected]>

* Add comments and fix tests

* Fix merge conflicts

Co-authored-by: Roman <[email protected]>
@ValarDragon @alexanderbez @p0mvn
Fix epochs modules tests (#1893)
21f7f98 
* Fix epochs modules tests

* Remove debug code

* Fix altered API usage within superfluid

* Add changelog entry

* Add more AddEpochInfo checks

* Fix superfluid tests

* Update osmoutils/slice_helper.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Changelog nit

* Apply Roman's suggestions!

Co-authored-by: Roman <[email protected]>

* add const

* Apply roman's suggestion of tests w/ non-default values

* Apply roman's comment update suggestions

* AddEpochInfo comment

* fix gomod order

Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Roman <[email protected]>
@dependabot
chore(deps): Bump github.com/stretchr/testify from 1.7.5 to 1.8.0 (#1899
33f5e40 
)

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.5 to 1.8.0.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.7.5...v1.8.0)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@p0mvn @czarcas7ic
e2e: chain initialization refactor for extensibility (#1898)
9f64027 
* refactor: e2e initialization package

* fix merge issues

* md lint

* update init image

* add logic for printing errors to debug containers

* environment variables in configuration docs

* Update tests/e2e/initialization/README.md

Co-authored-by: Adam Tucker <[email protected]>

* remove node script - to be added in future PR

Co-authored-by: Adam Tucker <[email protected]>
@p0mvn
fix: e2e flakiness related to err checking containers (#1902)
85529c7
@rrrliu
refactor FundCommunityPoolFromModule to use SDK (#1909)
f79a273
@ValarDragon @alexanderbez @p0mvn
Write test for AddEpochInfo (#1895)
76344cd 
* Write test for AddEpochInfo

* Remove prior todo comment

* Add failing test

* Update x/epochs/keeper/epoch_test.go

Co-authored-by: Roman <[email protected]>

Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Roman <[email protected]>
@hieuvubk
Locks amount invariant (#1884)
699b713 
* add invariant to check locks amount

* format
@nghuyenthevinh2000 @mattverse
Issue 1525: sub-section: combine superfluid query and staking query o…
52d46b2 
…n querying delegation by delegator (#1539)

* add normarl staking query for superfluid

* add TestGRPCQuerySuperfluidDelegationsWithNormalStaking

* add Query Delegation

* combine hieuvubk's work on Osmo equivalent. The idea belongs to hieuvubk

* change proto and cli

* minor

* change name to total-delegation-by-delegator

* another minor :v

* last minor

* Apply suggestions from code review

Co-authored-by: Matt, Park <[email protected]>

* apply changes from review

* add feature to changelog.md

* minor fix in changelog

Co-authored-by: Matt, Park <[email protected]>
@stackman27
[Query] Make pool incentives query show % of incentives going to that…
3790f88 
… gauge ID (#1815)

* added percentage

* added tests
@ValarDragon
We broke adding issues to Project, this fixes it (#1912)
a540ce7
@alexanderbez
chore: update labeler.yml (#1913)
b13fbff
@p0mvn @ValarDragon @mattverse
chore: x/mint docs and clean up, excluding mint keeper (#1857)
ee48cf5 
* chore: mint module docs and clean up

* rename LasteHalvenEpoch to LastReductionEpoch

* lint

* revert proto comments

* spec

* try removing simulation

* client module changes

* client/rest

* more proto fixes

* avoid listing minting params in spec

* Update proto/osmosis/mint/v1beta1/mint.proto

Co-authored-by: Dev Ojha <[email protected]>

* update comment in hooks.go

* Revert "try removing simulation" w/o Makefile change

This reverts commit 5a06bf1.

* randomize mint gen state simulation

* fix full sim tests

* fix TestAppStateDeterminism

* fix TestAppStateDeterminism

* change expected epochIdentifier to day

* address Dev's comments to hardcode certain parameters

* Update x/mint/types/minter_test.go

Co-authored-by: Dev Ojha <[email protected]>

* remove unused variable

* Update proto/osmosis/mint/v1beta1/genesis.proto

Co-authored-by: Matt, Park <[email protected]>

* Update proto/osmosis/mint/v1beta1/mint.proto

Co-authored-by: Matt, Park <[email protected]>

* Update x/mint/types/hooks.go

Co-authored-by: Matt, Park <[email protected]>

* make prot-all

* remove unused

Co-authored-by: Dev Ojha <[email protected]>
Co-authored-by: Matt, Park <[email protected]>
@p0mvn @alexanderbez
test: x/mint thirdening - identify rounding errors (#1874)
d9a4f94 
* test: x/mint thirdening

* add logic for estimating supply

* estimate expected supply w/o offset

* identify the sources of rounding issues

* transcribe calculations

* clean up for readability

* Update x/mint/keeper/hooks_test.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* fix merge conflicts and link a correct issue

Co-authored-by: Aleksandr Bezobchuk <[email protected]>
@AlpinYukseloglu @mattverse @alexanderbez
x/gamm: Internal audit and documentation (#1858)
15736e5 
* add many clarifying comments and docs for logic that was confusing during audit

* update comments for clarity

* Update x/gamm/keeper/multihop.go

Co-authored-by: Matt, Park <[email protected]>

* Update x/gamm/keeper/genesis.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Update x/gamm/keeper/genesis.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Update x/gamm/keeper/multihop.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Apply suggestions from code review

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* add more clarifying comments

* apply suggestions from review

Co-authored-by: Matt, Park <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
@alexanderbez
refactor: consolidate pool implementation (#1868)
e2d4911
@p0mvn
e2e: remove unused skipRunValidatorIndexes (#1923)
28fe669 
* e2e: remove unused skipRunValidatorIndexes

* remove error log
@p0mvn
e2e: fix image choice when upgrade logic is disabled (#1922)
add306e
@mattverse
chore: x/lockup documentation, module cleanup (#1900)
25bf1d8
@p0mvn
e2e: ExecCmd debug log on error (#1924)
5ba829f 
* e2e: ExecCmd debug log on error

* update

* update
@ValarDragon
Delete cmd/testnetify (#1933)
0f3e8b9
@AlpinYukseloglu
x/gamm: Add check to ensure JoinPoolNoSwap cannot be called with arbi…
01dee57 
…trary denoms (#1930)

* add denom equivalence check for input vs. expected

* add test for new logic

* refactor new logic and add more relevant error messages

* update changelog

* Revert "update changelog"

This reverts commit fa33bf7.

* Update changelog
@ValarDragon
Add deadcode linter (#1934)
c0573d1
@mattverse @xBalbinus
@p0mvn @alexanderbez
Generalize gamm Inverse relationship test , add Inverse relationship …
2007bab 
…test for stableswap (#1456)

* Generalize inverse testing from balancer package to pool-models

* Add stableswap inverse testing

* fixed failing lint test

* Update x/gamm/pool-models/internal/test_helpers/test_helpers.go

Co-authored-by: Roman <[email protected]>

* Add test

* Address Bez's review

* Fix test

* Update x/gamm/pool-models/internal/test_helpers/test_helpers.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

Co-authored-by: Xiangan He <[email protected]>
Co-authored-by: Xiangan He <[email protected]>
Co-authored-by: Roman <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
@AlpinYukseloglu
x/gamm: Delete the height < v10forkheight { use broken code } check (#…
fc11147 
…1941)

* remove height gating from JoinPool

* remove corresponding broken functions
@mattverse @ValarDragon
x/lock: Fix ExtendLockup API (#1937)
99304f2 
* Fix extendlock api

* Apply suggestions from code review

* Add changelog

Co-authored-by: Dev Ojha <[email protected]>
Co-authored-by: Dev Ojha <[email protected]>
@p0mvn @mattverse
chore: x/mint genesis - audit, clean up and tests (#1872)
b33920a 
* chore: audit, clean up and tests for mint genesis

* remove unused integration_test.go

* restore check for account existence in InitGenesis

* unit test CreateDeveloperVestingModuleAccount

* table-driven tests for SetInitialSupplyOffsetDuringMigration

* TestMintInitGenesis

* reduce suite verbosity in TestMintInitGenesis

* refactor TestSetInitialSupplyOffsetDuringMigration with setupDeveloperAccountTestcase

* refactor TestCreateDeveloperVestingModuleAccount with setupDeveloperAccountTestcase

* refactor  TestMintExportGenesis

* clean up

* lint errors

* remove height gated assertions; move module account creation test to TestMintInitGenesis

* Update x/mint/keeper/genesis_test.go

Co-authored-by: Matt, Park <[email protected]>

* Update x/mint/keeper/genesis_test.go

Co-authored-by: Matt, Park <[email protected]>

* Update x/mint/keeper/keeper.go

Co-authored-by: Matt, Park <[email protected]>

* address Matt's comment about supply offset

* Apply suggestions from code review

Co-authored-by: Matt, Park <[email protected]>

* remove init genesis keepers

* GetModuleAccount comment

* Update x/mint/keeper/genesis.go

Co-authored-by: Matt, Park <[email protected]>
ValarDragon and others added 24 commits July 2, 2022 20:04
@ValarDragon
Re-use code in superfluid TotalDelegationByDelegator (#1938)
197a9b1
@faddat
gofumpt matienance (#1948)
8f018a6
@p0mvn
lint: enable unused in golangci-lint (#1939)
aca83eb
@xBalbinus
Making CI for testing generated proto correctness (#1892)
0956d89
@p0mvn
lint: remove unused v10 fork height not caught during merge (#1953)
5be8292
@mattverse
refactor ref method (#1951)
1517e65
@p0mvn
lint: enable gosimple (#1957)
cc82980
@mattverse @alexanderbez
Refactor lock method (#1936)
c115593 
* Add lock method refactor

* Delete duplciated testing

* Update x/lockup/keeper/lock.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Add tests implement feedback from code review

* Add test cases

Co-authored-by: Aleksandr Bezobchuk <[email protected]>
@AlpinYukseloglu
x/gamm: Rename CalcExitPoolShares to CalcExitPoolCoinsFromShares #1970
14ca3fd
@hieuvubk
Clean up pool asset (#1967)
c35d886
@AlpinYukseloglu
x/gamm: Add check for correct input asset denoms to CalcJoinPoolShares (
49d632f 
#1931)
@stackman27
test/devux: helper function for assertions conditional on panics (#1964)
298d7cf 
* test: helper function for assertions conditional on panics

* added devs comments

* matts comment
@p0mvn
lint: enable stylecheck (#1960)
e398235 
* lint: stylecheck

* merge conflict

* pool asset lint
@p0mvn
e2e: refactor initialization with single node logic (#1963)
1da14b8 
* e2e: refactor initialization with single node logic

* lint and remove redundant getters from node

* restore accidental change

* rename init to InitChain

* persistentPeers typo
@p0mvn
lint: fix issue from parallel e2e pull request (#1974)
1a67b02
@alexanderbez @p0mvn
chore: x/tokenfactory audit (#1962)
133e139 
* updates

* updates

* updates

* updates

* Update x/tokenfactory/README.md

Co-authored-by: Roman <[email protected]>

* Update x/tokenfactory/module.go

Co-authored-by: Roman <[email protected]>

* updates

* updates

Co-authored-by: Roman <[email protected]>
@p0mvn
chore(e2e): update initialization image (#1976)
f0270d0
@mattverse @p0mvn
chore: refactor unlock test (#1968)
198a4de 
* Unlocking tests

* Add test cases

* Update x/lockup/keeper/lock_test.go

Co-authored-by: Roman <[email protected]>

* Apply suggestions from code review

Co-authored-by: Roman <[email protected]>

* cleanup

Co-authored-by: Roman <[email protected]>
@rrrliu
rename params.go to pool_params.go, consolidate pool functions to poo…
4fb906f 
…l.go (#1978)
@ValarDragon
Remove the EndBlock ordering constraints, that didn't matter before (#…
28417c0 
…1981)

* Remove the EndBlock ordering constraints, that didn't matter before

* Remove unused superfluid end block logic
@ValarDragon
Add TWAP stub package (#1982)
a364494 
* Add TWAP stub package

* Fix unused lint
@ValarDragon
Merge branch 'main' into dev/takeover_1886
33dc056
@ValarDragon
Add Changelog
920b74e
@ValarDragon
Add requested test updates
63e976b
@ValarDragon ValarDragon mentioned this pull request Jul 7, 2022
Merged
@Ehsan-saradar Ehsan-saradar merged commit b2411d1 into quasar-finance:feature/add_details_to_join_exit_pool_reponse Jul 7, 2022
@ValarDragon ValarDragon deleted the dev/takeover_1886 branch August 12, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.