-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: x/mint thirdening - identify rounding errors #1874
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naser531900
approved these changes
Jun 27, 2022
p0mvn
changed the title
test: x/mint thirdening
test: x/mint thirdening - identify rounding errors
Jun 28, 2022
alexanderbez
approved these changes
Jun 30, 2022
ValarDragon
approved these changes
Jun 30, 2022
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Jul 19, 2022
* test: x/mint thirdening * add logic for estimating supply * estimate expected supply w/o offset * identify the sources of rounding issues * transcribe calculations * clean up for readability * Update x/mint/keeper/hooks_test.go Co-authored-by: Aleksandr Bezobchuk <[email protected]> * fix merge conflicts and link a correct issue Co-authored-by: Aleksandr Bezobchuk <[email protected]> (cherry picked from commit d9a4f94)
p0mvn
added a commit
that referenced
this pull request
Jul 19, 2022
p0mvn
added a commit
that referenced
this pull request
Jul 19, 2022
…2154) Co-authored-by: Roman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #1839
What is the purpose of the change
There have been concerns about minting rounding errors that were causing total osmo supply to be slightly off.
This change root causes some of the rounding issues related to total supply. The newly introduced test identifies the 2 sources:
The test works by running
AfterEpochEnd
hook 366 times (until and including thirdening). Before the 366thAfterEpochEnd
, we make an assertion on the total supply.If the aforementioned assertion was to be made directly against the actual osmo supply value, it would be off by
2619.999999999999999705
. Instead, we accumulate the delta from the two rounding error sources and add them to the actual supply value to make the assertion pass:Essentially, this test helps to root cause the rounding errors. We should refactor and fix the rounding errors. Then, the test should potentially be removed.
Testing and Verifying
go test -timeout 30s -run ^TestAfterEpochEnd_FirstYearThirdening_RealParameters$ github.com/osmosis-labs/osmosis/v7/x/mint/keeper
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? no