test/devux: helper function for assertions conditional on panics

[stackman27]

Closes: #1946

What is the purpose of the change

Adds a helper function for conditioning on Panics
Realized that there is already a helper function in x/gamm/pool-models/balancer/util_test.go so i just moved that under osmoutils

Brief Changelog

n/a

Testing and Verifying

n/a

Documentation and Release Note

• Does this pull request introduce a new feature or user-facing behavior changes? (no)
• Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (no)
• How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

[stackman27]

We could use something similar for conditionalErrors, but it is going to be a little more complex. These are 4 ways that i've found expectError being used ;

1. Basic implementation

if tc.expectErr {
    require.Error(t, err)
} else {
    require.NoError(t, err)
}

2. Error with message

if test.expectPass {
   require.NoError(t, test.msg.ValidateBasic(), "test: %v", test.name)
} else {
   require.Error(t, test.msg.ValidateBasic(), "test: %v", test.name)
}

3. Checks after NoError

if tc.expectErr {
	require.Error(t, err)
} else {
	require.NoError(t, err)
	require.NotNil(t, resp)
	require.Equal(t, tc.expectAdmin, resp.Admin)
}

4. Check that halts after error

if tc.expErr {
    require.Error(t, gotErr)
    return
}
require.NoError(t, gotErr)

If this is something that we should add. Please let me know and i can add it in this PR :)

[ValarDragon]

Thanks for adding this! Would recommend we don't do this for expect pass atm

[stackman27]

Thanks for adding this! Would recommend we don't do this for expect pass atm

Thank you @ValarDragon! Resolved your comments

[mattverse]

Logic and feature LGTM!

I'd prefer creating a new file test_helpers.go in osmo utils instead of having the method within cli_helpers

[p0mvn]

Sweet, LGTM once Matt's suggestion to move to a different file is addressed

[stackman27]

Addressed all the comments. Good to go!

addressed