Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: fix image choice when upgrade logic is disabled #1922

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Jun 30, 2022

Closes: #XXX

What is the purpose of the change

Due to a missing return, the image would get overwritten by incorrect value when running e2e with upgrade tests disabled. This short change fixes it

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@p0mvn p0mvn marked this pull request as ready for review June 30, 2022 22:24
@p0mvn p0mvn requested a review from a team June 30, 2022 22:24
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, this was probably my fault. Thanks for correcting!

@p0mvn p0mvn merged commit add306e into main Jun 30, 2022
@p0mvn p0mvn deleted the roman/e2e-fix-image-choice branch June 30, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants