Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the EndBlock ordering constraints, that didn't matter before #1981

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Remove the EndBlock ordering constraints, that didn't matter before #1981

merged 2 commits into from
Jul 6, 2022

Conversation

ValarDragon
Copy link
Member

What is the purpose of the change

Epochs, txfees, and gamm have no endblock logic. So the prior constraints had no impact.

Brief Changelog

  • Remove some unnecessary logic.
  • Remove the deadcode, to make it clearer superfluid has no endblock logic.

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage. Just check the following lines to convince yourself of no EndBlock logic:

epochs - https://github.com/osmosis-labs/osmosis/blob/main/x/epochs/module.go#L157-L161
gamm - https://github.com/osmosis-labs/osmosis/blob/main/x/gamm/module.go#L149-L153
txfees - https://github.com/osmosis-labs/osmosis/blob/main/x/txfees/module.go#L162-L167

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@ValarDragon ValarDragon requested a review from a team July 6, 2022 19:56
@github-actions github-actions bot added C:app-wiring Changes to the app folder C:x/superfluid labels Jul 6, 2022
@p0mvn p0mvn merged commit 28417c0 into main Jul 6, 2022
@p0mvn p0mvn deleted the dev/remove_endblock_constraint branch July 6, 2022 22:52
@ValarDragon ValarDragon added the A:backport/v10.x backport patches to v10.x branch label Jul 12, 2022
mergify bot pushed a commit that referenced this pull request Jul 12, 2022
@ValarDragon @mergify
Remove the EndBlock ordering constraints, that didn't matter before (#…
55fb510 
…1981)

* Remove the EndBlock ordering constraints, that didn't matter before

* Remove unused superfluid end block logic

(cherry picked from commit 28417c0)

# Conflicts:
#	x/superfluid/abci.go
@mergify mergify bot mentioned this pull request Jul 12, 2022
Merged
ValarDragon added a commit that referenced this pull request Jul 15, 2022
@mergify @ValarDragon
Remove the EndBlock ordering constraints, that didn't matter before (…
f30b3f1 
…backport #1981) (#2037)

* Remove the EndBlock ordering constraints, that didn't matter before (#1981)

* Remove the EndBlock ordering constraints, that didn't matter before

* Remove unused superfluid end block logic

(cherry picked from commit 28417c0)

# Conflicts:
#	x/superfluid/abci.go

* Update abci.go

* Update abci.go

Co-authored-by: Dev Ojha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0mvn p0mvn p0mvn approved these changes

Assignees
No one assigned
Labels
A:backport/v10.x backport patches to v10.x branch C:app-wiring Changes to the app folder C:x/superfluid
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ValarDragon @p0mvn