Feature/add details to join exit pool reponse #1886
Conversation
github-actions
bot
added
C:x/gamm
There was a problem hiding this comment.
Thanks for this PR! I personally think adding responses to messages are super useful.
Can we make sure we add new test cases and checks for the new fields to ensure they return expected values?
Also, can you drop the changes for go.mod and go.sum as well? Otherwise, logic itself
lgtm!
| @@ -296,7 +298,7 @@ func (suite *KeeperTestSuite) TestJoinPoolNoSwap() { | |||
| keeper := suite.App.GAMMKeeper | |||
| // Test the "tokenInMaxs" | |||
| // In this case, to get the 50 * OneShare amount of share token, the foo, bar token are expected to be provided as 5000 amounts. | |||
| err := keeper.JoinPoolNoSwap(suite.Ctx, suite.TestAccs[1], poolId, types.OneShare.MulRaw(50), sdk.Coins{ | |||
| _, _, err := keeper.JoinPoolNoSwap(suite.Ctx, suite.TestAccs[1], poolId, types.OneShare.MulRaw(50), sdk.Coins{ | |||
There was a problem hiding this comment.
Can we add check and test ShareOutAmount and TokenIn returned here is as expected?
| @@ -493,7 +495,7 @@ func (suite *KeeperTestSuite) TestJoinPoolExitPool_InverseRelationship() { | |||
| balanceBeforeJoin := suite.App.BankKeeper.GetAllBalances(suite.Ctx, joinPoolAcc) | |||
| fmt.Println(balanceBeforeJoin.String()) | |||
|
|
|||
| err = suite.App.GAMMKeeper.JoinPoolNoSwap(suite.Ctx, joinPoolAcc, poolId, tc.joinPoolShareAmt, sdk.Coins{}) | |||
| _, _, err = suite.App.GAMMKeeper.JoinPoolNoSwap(suite.Ctx, joinPoolAcc, poolId, tc.joinPoolShareAmt, sdk.Coins{}) | |||
There was a problem hiding this comment.
ditto:Can we add check and test ShareOutAmount and TokenIn returned here is as expected?
|
Needs changelog entry as well, but feature looks good to me! |
|
Ok so that this doesn't get blocked, going to work on a PR into this branch that should suffice! |
There was a problem hiding this comment.
Reviewed the changes made in quasar-finance#2 Let's merge this once quasar-finance#2 gets merged!
Dev/takeover 1886
What is the purpose of the change
This PR adds more information to response of join/exit pool handlers so the caller of the transaction in ICA receives these information on acknowledgment.
Brief Changelog
tokenIn sdk.Coins,sharesOut sdk.Intto return ofJoinPoolNoSwapshare_out_amountandtoken_infields toMsgJoinPoolResponsetoken_outfield toMsgExitPoolResponseTesting and Verifying
This change added tests and can be verified as follows:
TestJoinPoolNoSwapDocumentation and Release Note
Unreleasedsection inCHANGELOG.md? (no)