Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gather v12 QA items #2444

Closed
ValarDragon opened this issue Aug 18, 2022 · 7 comments
Closed

Gather v12 QA items #2444

ValarDragon opened this issue Aug 18, 2022 · 7 comments
Assignees
Milestone

Comments

@ValarDragon
Copy link
Member

Background

Lets have two people independently check the diff from main and v11.x and gather the list of state machine / client relevant files that have changed (e.g. what matters, not docs updates or e2e / simulator)

We should have two people do this for the redundancy aspect

Then we make a QA strategy off of these.

@ValarDragon ValarDragon added this to the V12 Blockers milestone Aug 18, 2022
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Aug 18, 2022
@czarcas7ic czarcas7ic moved this from Needs Review 🔍 to In Progress🏃 in Osmosis Chain Development Aug 18, 2022
@czarcas7ic
Copy link
Member

In trying to keep this list as succinct as possible, I am also going to exclude commits that ONLY change tests and does not change the logic itself. Lmk if you agree

@czarcas7ic
Copy link
Member

czarcas7ic commented Aug 19, 2022

This is what I got on a first pass. I can go into depth about what specifically we should be testing, but I though the first step was going through each file and find the PRs that changed important files in ways that potentially changes logic / would just be good to double check:

Should Consider In QA

Integrator Notes

Random Stuff

@ValarDragon
Copy link
Member Author

ValarDragon commented Aug 22, 2022

  • osmomath/math.go (adding base is negative check), sanity check this should never happen
  • gamm proto fields being made to be snake case instead of camel case. (Need to figure out how to make this not an ecosystem break)
  • Review gamm proto message responses (were they done correctly / as you'd expect?)
  • proto/superfluid - check if we deleted some queries? Unclear to me on quick skim
  • TokenFactory setDenomMetadata message. I remain worried about unclarity around bank registry, I think we just setup another registry for display data.
  • TWAP
  • Review wasmbinding differences
    {app/wasm => wasmbinding}/README.md | 6 +-
    {app/wasm => wasmbinding}/bindings/msg.go | 2 +-
    {app/wasm => wasmbinding}/bindings/pool.go | 2 +-
    {app/wasm => wasmbinding}/bindings/query.go | 44 +-
    {app/wasm => wasmbinding}/bindings/types.go | 2 +-
    {app/wasm => wasmbinding}/bindings/types_test.go | 2 +-
    {app/wasm => wasmbinding}/message_plugin.go | 42 +-
  • x/epochs difference - https://github.com/osmosis-labs/osmosis/blob/main/x/epochs/keeper/abci.go#L19-L21
  • x/gamm
  • x/incentives
    • TODO
  • x/lockup
    • TODO
  • x/pool-incentives
    • TODO
  • x/superfluid
    • TODO
  • x/tokenfactory
    • TODO
  • x/TWAP
    • Review logic
    • Review safety of all external module calls & arithmetic (no panics should be possible in beginblock/endblock)
  • Cosmwasm stargate queries
  • Tests for items in v12 upgrade handler

@czarcas7ic
Copy link
Member

Write single tracker issue of items people can test indv

@p0mvn
Copy link
Member

p0mvn commented Sep 23, 2022

Requesting one more review on this SDK PR please if anyone has time: osmosis-labs/cosmos-sdk#265

@p0mvn
Copy link
Member

p0mvn commented Sep 30, 2022

This can now be closed

@p0mvn p0mvn closed this as completed Sep 30, 2022
Repository owner moved this from In Progress🏃 to Done ✅ in Osmosis Chain Development Sep 30, 2022
@alexanderbez
Copy link
Contributor

Woohooo nice work team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants