-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update Proto + ~~ORM Support~~ #1589
Conversation
Seems like the |
But it seems like all the contents in that directory are auto-generated? |
Doesn't hurt to try a mkdir -p |
If you don't use |
Originally, I was thinking to not include the ./scripts/protocgen2.sh until you will like to use pulsar and ORM. |
@ValarDragon stated we want to introduce support for ORM, but idk what that looks like. |
Should we use Pulsar? I didn't realize ORM and Pulsar came together, my bad then. Would like to not have to force a switch of everything to the API module, I was under the impression from the regen codebase that just ORM things went there, and the normal proto files were being compiled as they are today |
Those warnings are present on main as well |
That's right. Currently there's a hybrid approach |
I think we should still merge this as it uses the new buf stuff (heh), but just remove the |
Co-authored-by: Roman <[email protected]>
* Revert "chore: Update Proto + ~~ORM Support~~ (#1589)" This reverts commit f291e12. * Update scripts/protocgen.sh Co-authored-by: Roman <[email protected]> * Run buf mod update * query gen * Change pb Co-authored-by: Roman <[email protected]>
* Revert "chore: Update Proto + ~~ORM Support~~ (#1589)" This reverts commit f291e12. * Update scripts/protocgen.sh Co-authored-by: Roman <[email protected]> * Run buf mod update * query gen * Change pb Co-authored-by: Roman <[email protected]> (cherry picked from commit 79adab9)
… (#2720) * Revert "chore: Update Proto + ~~ORM Support~~ (#1589)" (#2614) * Revert "chore: Update Proto + ~~ORM Support~~ (#1589)" This reverts commit f291e12. * Update scripts/protocgen.sh Co-authored-by: Roman <[email protected]> * Run buf mod update * query gen * Change pb Co-authored-by: Roman <[email protected]> (cherry picked from commit 79adab9) * Fix proto check Co-authored-by: Matt, Park <[email protected]> Co-authored-by: mattverse <[email protected]>
A re-attempt of #1455, but I've reached the capacity of my knowledge here. Maybe @robert-zaremba or @aaronc can chime in on how to get this to the finish line.
Currently, running
make proto-gen
yields:It also produces an erroneous
v7/
dir in the root.