-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Robert/update protogen #1455
Robert/update protogen #1455
Conversation
There are some proto build errors related to imports. |
Codecov Report
@@ Coverage Diff @@
## main #1455 +/- ##
==========================================
- Coverage 19.82% 19.51% -0.32%
==========================================
Files 202 229 +27
Lines 27685 32097 +4412
==========================================
+ Hits 5489 6263 +774
- Misses 21175 24704 +3529
- Partials 1021 1130 +109
Continue to review full report at Codecov.
|
Thanks for updating Osmosis to the newer setup! Is there something I can read up on to understand the differences? |
Thanks Robert! at least 15x better than the docker way. :) |
--grpc-gateway_out=logtostderr=true:. \ | ||
$(find "${dir}" -maxdepth 1 -name '*.proto') | ||
done | ||
go mod tidy -compat=1.17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we make this:
go mod tidy -go=1.18
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, because we want to use it in 0.46
Robert, does this script you added also depend on a protocgen2.sh file? I have like
|
No, it doesn't need protocgen2.sh - because the Pulsar is not used by Osmosis yet. That would require bigger migration, which can be done step by step. |
A re-attempt of #1455, but I've reached the capacity of my knowledge here. Maybe @robert-zaremba or @aaronc can chime in on how to get this to the finish line. Currently, running `make proto-gen` yields: ``` make proto-gen Generating Protobuf files Generating gogo proto code WARNING: field Pool.ScalingFactor is a repeated non-nullable native type, nullable=false has no effect WARNING: field Pool.ScalingFactor is a repeated non-nullable native type, nullable=false has no effect WARNING: field MsgStableSwapAdjustScalingFactors.ScalingFactors is a repeated non-nullable native type, nullable=false has no effect Cleaning API directory ./scripts/protocgen2.sh: cd: line 14: can't cd to api: No such file or directory make: *** [proto-gen] Error 2 ``` It also produces an erroneous `v7/` dir in the root.
Superseded by #1589 |
A re-attempt of osmosis-labs/osmosis#1455, but I've reached the capacity of my knowledge here. Maybe @robert-zaremba or @aaronc can chime in on how to get this to the finish line. Currently, running `make proto-gen` yields: ``` make proto-gen Generating Protobuf files Generating gogo proto code WARNING: field Pool.ScalingFactor is a repeated non-nullable native type, nullable=false has no effect WARNING: field Pool.ScalingFactor is a repeated non-nullable native type, nullable=false has no effect WARNING: field MsgStableSwapAdjustScalingFactors.ScalingFactors is a repeated non-nullable native type, nullable=false has no effect Cleaning API directory ./scripts/protocgen2.sh: cd: line 14: can't cd to api: No such file or directory make: *** [proto-gen] Error 2 ``` It also produces an erroneous `v7/` dir in the root.
A re-attempt of osmosis-labs/osmosis#1455, but I've reached the capacity of my knowledge here. Maybe @robert-zaremba or @aaronc can chime in on how to get this to the finish line. Currently, running `make proto-gen` yields: ``` make proto-gen Generating Protobuf files Generating gogo proto code WARNING: field Pool.ScalingFactor is a repeated non-nullable native type, nullable=false has no effect WARNING: field Pool.ScalingFactor is a repeated non-nullable native type, nullable=false has no effect WARNING: field MsgStableSwapAdjustScalingFactors.ScalingFactors is a repeated non-nullable native type, nullable=false has no effect Cleaning API directory ./scripts/protocgen2.sh: cd: line 14: can't cd to api: No such file or directory make: *** [proto-gen] Error 2 ``` It also produces an erroneous `v7/` dir in the root.
What is the purpose of the change
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? (yes / no)x/<module>/spec/
) / Osmosis docs repo / not documented)