Revert "chore: Update Proto + ~~ORM Support~~ (#1589)" #2614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f291e12.
github-actions
bot
added
C:CLI
C:x/epochs
C:x/gamm
p0mvn
approved these changes
Sep 8, 2022
Co-authored-by: Roman <[email protected]>
…s/osmosis into mattverse/orm-revert
github-actions
bot
removed
C:x/pool-incentives
C:x/epochs
C:x/incentives
C:x/gamm
mergify bot
pushed a commit
that referenced
this pull request
Sep 13, 2022
* Revert "chore: Update Proto + ~~ORM Support~~ (#1589)" This reverts commit f291e12. * Update scripts/protocgen.sh Co-authored-by: Roman <[email protected]> * Run buf mod update * query gen * Change pb Co-authored-by: Roman <[email protected]> (cherry picked from commit 79adab9)
p0mvn
pushed a commit
that referenced
this pull request
Sep 14, 2022
… (#2720) * Revert "chore: Update Proto + ~~ORM Support~~ (#1589)" (#2614) * Revert "chore: Update Proto + ~~ORM Support~~ (#1589)" This reverts commit f291e12. * Update scripts/protocgen.sh Co-authored-by: Roman <[email protected]> * Run buf mod update * query gen * Change pb Co-authored-by: Roman <[email protected]> (cherry picked from commit 79adab9) * Fix proto check Co-authored-by: Matt, Park <[email protected]> Co-authored-by: mattverse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f291e12.
Some of the changes that were made in #1589 were changes that we wanted to keep(how we use buf gen to protogen, for example), making the scope of this PR not only simply revert the commit, but keep some of the updated process for proto gen that were initially included in #1589