fix: check coins are positive in lockup ValidateBasic #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
approved these changes
Jul 21, 2022
alexanderbez
approved these changes
Jul 22, 2022
ValarDragon
approved these changes
Jul 22, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
@ValarDragon had mentioned that the fact ValidateBasic was not catching zero amount lockups in the simulator was a bug. This fixes that bug.
Brief Changelog
Testing and Verifying
To test that this worked, I made every lockup have a zero amount in the simulator and ran it through the ValidateBasic. No lockups errored.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no