improve getToDistributedCoinsFromGauges #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackman27
reviewed
Jul 10, 2022
| @@ -21,9 +21,14 @@ func (k Keeper) getDistributedCoinsFromGauges(gauges []types.Gauge) sdk.Coins { | |||
| } | |||
|
|
|||
| func (k Keeper) getToDistributeCoinsFromGauges(gauges []types.Gauge) sdk.Coins { | |||
| // TODO: Consider optimizing this in the future to only require one iteration over all gauges. | |||
| coins := k.getCoinsFromGauges(gauges) | |||
There was a problem hiding this comment.
func (k Keeper) getCoinsFromGauges(gauges []types.Gauge) sdk.Coins {..} is unused now, maybe you can remove it
There was a problem hiding this comment.
thanks, I'll remove it
stackman27
approved these changes
Jul 10, 2022
alexanderbez
approved these changes
Jul 10, 2022
mattverse
approved these changes
Jul 11, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2005
What is the purpose of the change
Change
getToDistributeCoinsFromGaugesso that it only iterate through all gauges once.Testing and Verifying
This change is already covered by existing tests
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no