x/gamm: Add fixed gas cost for swaps #2016

rrrliu · 2022-07-11T07:33:50Z

Closes: #1903

What is the purpose of the change

To further prevent spam, adds fixed amount of gas we consume per swap in/out. Previously we had only been consuming gas for built-in I/O (store reads and writes), and in the future we might make

Brief Changelog

Added new BalancerGasFeeForSwap constant + TODO comment to turn into param
Have swapExactAmountIn and swapExactAmountOut consume gas
Test this in swap_test.go

Testing and Verifying

This change added tests and can be verified as follows:

Added lines to test gas consumed in swap_test.go

Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? (yes)
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

alexanderbez · 2022-07-11T14:38:52Z

x/gamm/types/constants.go

@@ -12,6 +12,8 @@ const (
 	// Raise 10 to the power of SigFigsExponent to determine number of significant figures.
 	// i.e. SigFigExponent = 8 is 10^8 which is 100000000. This gives 8 significant figures.
 	SigFigsExponent = 8
+	// TODO: Current fixed cost gas fee per swap -- turn this into a param in the future.
+	GasFeeForSwap = 10000


Is there a reason to not directly just make this a param?

We decided to make it a fixed cost for now to avoid needing to set up migration code for a change this small (#1903 (comment))

alexanderbez · 2022-07-11T14:39:19Z

x/gamm/keeper/swap.go

@@ -49,6 +49,7 @@ func (k Keeper) swapExactAmountIn(
 	}
 	tokensIn := sdk.Coins{tokenIn}

+	ctx.GasMeter().ConsumeGas(types.GasFeeForSwap, "swap computation")


It feels safer to move the gas consumption to the top-most level of abstraction, i.e the msg handler for swapping.

I think it should be in each core loop here right, so that we scale by number of hops in a multi-hop?

(Also needs to be in swapExactAmountOut)

I guess really it should probably be defined per pool type

Thoughts on applying it right here: https://github.com/osmosis-labs/osmosis/blob/main/x/gamm/pool-models/balancer/pool.go#L585-L599 ?

That way we have it per Balancer swap, rather than per total swap. (And can then later charge a different gas amount for stableswap / next CFMM)

Yeah that makes sense, just updated! Should we update balancer pool docs with this or should we wait until it becomes a param?

x/gamm/types/constants.go

x/gamm/keeper/swap_test.go

mattverse

LGTM! Can we add a Changelog entry for this PR?

mattverse · 2022-07-13T11:28:31Z

Also out of curiousity, how was the constant 10000 decided?

p0mvn · 2022-07-13T15:37:35Z

x/gamm/types/constants.go

@@ -12,6 +12,8 @@ const (
 	// Raise 10 to the power of SigFigsExponent to determine number of significant figures.
 	// i.e. SigFigExponent = 8 is 10^8 which is 100000000. This gives 8 significant figures.
 	SigFigsExponent = 8
+	// TODO: Turn this into a param in the future.


Great idea! Can we make an issue for this please and remove the comment?

Yes, issue please with a reference 👍

Created one! #2058

CHANGELOG.md

alexanderbez · 2022-07-13T17:08:52Z

x/gamm/types/constants.go

@@ -12,6 +12,8 @@ const (
 	// Raise 10 to the power of SigFigsExponent to determine number of significant figures.
 	// i.e. SigFigExponent = 8 is 10^8 which is 100000000. This gives 8 significant figures.
 	SigFigsExponent = 8
+	// TODO: Turn this into a param in the future.


Yes, issue please with a reference 👍

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

rrrliu · 2022-07-15T04:56:11Z

Also out of curiousity, how was the constant 10000 decided?

@mattverse oh I just benchmarked the swap i/o gas and it was around ~40000, so decided to have it be something around the same order of magnitude. No strong opinion on this though so open to changing.

ValarDragon · 2022-07-15T12:27:23Z

Thanks for making this!

mattverse · 2022-07-15T16:13:29Z

@rrrliu ah gotcha thanks for explaining! Nice work done here!

* add gas for swap + test * test file comments * move swap consumption to balancer only * fix one more test case * add to changelog * Update CHANGELOG.md Co-authored-by: Aleksandr Bezobchuk <[email protected]> * rm TODO now that we have issue * underscore for clarity * gofmt Co-authored-by: Aleksandr Bezobchuk <[email protected]>

add gas for swap + test

557fac4

rrrliu requested a review from a team July 11, 2022 07:33

github-actions bot added the C:x/gamm Changes, features and bugs related to the gamm module. label Jul 11, 2022

alexanderbez reviewed Jul 11, 2022

View reviewed changes

AlpinYukseloglu reviewed Jul 11, 2022

View reviewed changes

x/gamm/types/constants.go Outdated Show resolved Hide resolved

x/gamm/keeper/swap_test.go Outdated Show resolved Hide resolved

rrrliu added 3 commits July 11, 2022 23:54

test file comments

88e6112

move swap consumption to balancer only

4bdfc68

fix one more test case

44abd66

rrrliu requested review from ValarDragon, AlpinYukseloglu and alexanderbez July 13, 2022 02:48

mattverse approved these changes Jul 13, 2022

View reviewed changes

add to changelog

7eed0c3

github-actions bot added the C:docs Improvements or additions to documentation label Jul 13, 2022

p0mvn reviewed Jul 13, 2022

View reviewed changes

alexanderbez reviewed Jul 13, 2022

View reviewed changes

rrrliu and others added 5 commits July 14, 2022 00:29

Update CHANGELOG.md

5190924

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

rm TODO now that we have issue

df0f26b

underscore for clarity

5ea427f

gofmt

29ad32a

Merge branch 'main' into rrrliu/1903-charge-gas-for-computation

3cbb9dc

ValarDragon approved these changes Jul 15, 2022

View reviewed changes

ValarDragon merged commit e9907ce into osmosis-labs:main Jul 17, 2022

czarcas7ic mentioned this pull request Aug 19, 2022

Gather v12 QA items #2444

Closed

czarcas7ic mentioned this pull request Sep 15, 2022

Revert fixed gas costs for swaps #2758

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/gamm: Add fixed gas cost for swaps #2016

x/gamm: Add fixed gas cost for swaps #2016

rrrliu commented Jul 11, 2022 •

edited

Loading

alexanderbez Jul 11, 2022

AlpinYukseloglu Jul 11, 2022 •

edited

Loading

alexanderbez Jul 11, 2022

ValarDragon Jul 11, 2022

ValarDragon Jul 11, 2022

ValarDragon Jul 11, 2022

ValarDragon Jul 11, 2022

rrrliu Jul 12, 2022

mattverse left a comment

mattverse commented Jul 13, 2022

p0mvn Jul 13, 2022

alexanderbez Jul 13, 2022

rrrliu Jul 14, 2022

alexanderbez Jul 13, 2022

rrrliu commented Jul 15, 2022

ValarDragon commented Jul 15, 2022

mattverse commented Jul 15, 2022

x/gamm: Add fixed gas cost for swaps #2016

x/gamm: Add fixed gas cost for swaps #2016

Conversation

rrrliu commented Jul 11, 2022 • edited Loading

What is the purpose of the change

Brief Changelog

Testing and Verifying

Documentation and Release Note

Choose a reason for hiding this comment

AlpinYukseloglu Jul 11, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mattverse left a comment

Choose a reason for hiding this comment

mattverse commented Jul 13, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rrrliu commented Jul 15, 2022

ValarDragon commented Jul 15, 2022

mattverse commented Jul 15, 2022

rrrliu commented Jul 11, 2022 •

edited

Loading

AlpinYukseloglu Jul 11, 2022 •

edited

Loading