Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/gamm: Make gas cost per swap a param #2058

Closed
rrrliu opened this issue Jul 14, 2022 · 1 comment
Closed

x/gamm: Make gas cost per swap a param #2058

rrrliu opened this issue Jul 14, 2022 · 1 comment
Assignees
@alexanderbez

Comments

@rrrliu
Copy link
Contributor

rrrliu commented Jul 14, 2022

Background

Follow up to #1903 (comment), make this fixed gas fee into a pool-level param for more customizability.

Right now we use a BalancerGasFeeForSwap fixed constant, we'll need to update that logic when we swap.

Suggested Design

Add a new field to PoolParams for balancer and stableswap pools, use this field to consume gas during applySwap.

Acceptance Criteria

  • PoolParams struct updated, prepare for contract migration
  • Unit tests in pool_test.go and updated tests in swap_test.go
@rrrliu rrrliu mentioned this issue Jul 14, 2022
Merged
@alexanderbez alexanderbez self-assigned this Jul 14, 2022
@alexanderbez
Copy link
Contributor

Per chain-dev call, we decided to keep this as a static-hard coded value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderbez alexanderbez

Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexanderbez @rrrliu