chore: Rename ResetAllLocks
#1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
approved these changes
Jul 4, 2022
|
Nice improvement! |
mergify bot
pushed a commit
that referenced
this pull request
Jul 12, 2022
(cherry picked from commit 1517e65) # Conflicts: # x/lockup/keeper/bench_test.go
mattverse
added a commit
that referenced
this pull request
Jul 12, 2022
* refactor ref method (#1951) (cherry picked from commit 1517e65) # Conflicts: # x/lockup/keeper/bench_test.go * Fix merge conflict Co-authored-by: Matt, Park <[email protected]> Co-authored-by: mattverse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1275
Sub-component of #1838
What is the purpose of the change
The method
ResetAllLocksimplies resetting a state, which implies we're deleting an existing state, and setting a new value for the state. This method name is misleading, as this method is not resetting an existing state, it's simply initializing a state, asResetAllLocksare used inInitGenesis.This PR includes renaming
ResetAllLockstoInitializeAllLocks.This PR also includes renaming
setLockAndResetLockRefstosetLockAndAddLockRefs, as the intention of the method is not to delete and add lock refs, but simply add lock refs.Brief Changelog
ResetAllLockstoInitializeAllLocks, renamesetLockAndResetLockRefstosetLockAndAddLockRefsDocumentation and Release Note
Unreleasedsection inCHANGELOG.md? no