Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: remove unused skipRunValidatorIndexes #1923

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Jun 30, 2022

Closes: #XXX

What is the purpose of the change

This was originally meant to be used for initializing genesis and configs for state-sync nodes and be able to run them after the rest of the chain has started. However, a new design was chosen over this where we have the ability to initialize the configs for a single node, separate from the rest of the chain

As a result, this logic is not needed anymore

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@p0mvn p0mvn marked this pull request as ready for review June 30, 2022 22:47
@p0mvn p0mvn requested a review from a team June 30, 2022 22:47
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am glad we are doing away with this, it was just one more thing to remember to do when going through the setup process (also it oddly took a long time to just skip the validator, at least when looking at the logs)

@p0mvn
Copy link
Member Author

p0mvn commented Jun 30, 2022

@czarcas7ic thanks for quick reviews everywhere

@p0mvn p0mvn merged commit 28fe669 into main Jun 30, 2022
@p0mvn p0mvn deleted the roman/e2e-skipRunValidatorIndexes branch June 30, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants