chore: x/tokenfactory audit #1962
Conversation
|
Not sure why, but after modifying the proto schemas and running |
github-actions
bot
added
C:docs
I tried running Maybe try |
x/tokenfactory/README.md
Outdated
| allows changing the master admin account, or even setting it to | ||
| `""`, meaning no account has admin privileges of the asset. | ||
|
|
||
| - Change the admin In the future, more admin capabilities may be added. Admins |
There was a problem hiding this comment.
Asking to learn - what are the current admin capabilities? They are not implemented yet, is that correct?
There was a problem hiding this comment.
AFAIK, current admin caps are just who created the token and that gives them the ability to perform certain actions. It does not extend beyond that AFAIK.
cc @sunnya97
There was a problem hiding this comment.
The current admin capabilities are only minting and burning
| - Burning of a specific denom is only allowed for the creator of the denom registered during `CreateDenom` | ||
| ``` {.go} | ||
|
|
||
| Burning of a specific denom is only allowed for the creator of the denom |
There was a problem hiding this comment.
I think this text might be about Burn, not ChangeAdmin
Co-authored-by: Roman <[email protected]>
Co-authored-by: Roman <[email protected]>
|
@p0mvn I tried both commands and I get no diff. I'm not sure but maybe it's because I'm on an m1 chip? Regardless, I have zero issues compiling proto in the SDK repo... |
That's weird. Probably, a machine-specific issue. I made #1971 to your PR to see if that fixes CI. This is what my Linux machine produces from your branch |
|
Did you find nothing odd in the logic / tests / events of token factory? |
I think test coverage could improve, but what is there there now looks sufficient. |
Closes: #1914
What is the purpose of the change
Auditing the
x/tokenfactorymoduleBrief Changelog