Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call For Participation: vectorize all String builtin functions #12106

Closed
qw4990 opened this issue Sep 10, 2019 · 37 comments
Closed

Call For Participation: vectorize all String builtin functions #12106

qw4990 opened this issue Sep 10, 2019 · 37 comments
Labels
component/expression good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@qw4990
Copy link
Contributor

qw4990 commented Sep 10, 2019 •
edited
Loading

This issue is used to trace all vectorized Real builtin functions, which is a part of #12058.

NOTE:

  1. Feel free to join us in the wg-vec-expr working group
  2. Please comment on this issue if you are working on any of the functions.

Note For Performance Challenge Teams: each PR on this issue has 50 score.

  • builtinCastIntAsStringSig
  • builtinCastRealAsStringSig
  • builtinCastDecimalAsStringSig
  • builtinCastStringAsStringSig
  • builtinCastTimeAsStringSig
  • builtinCastDurationAsStringSig
  • builtinCastJSONAsStringSig
  • builtinCoalesceStringSig
  • builtinGreatestStringSig
  • builtinGreatestTimeSig
  • builtinLeastStringSig
  • builtinLeastTimeSig
  • builtinCaseWhenStringSig
  • builtinIfStringSig executor: go generate builtin_control_vec.go #12140
  • builtinIfNullStringSig
  • builtinAesDecryptSig
  • builtinAesDecryptIVSig
  • builtinAesEncryptSig
  • builtinAesEncryptIVSig
  • builtinDecodeSig
  • builtinEncodeSig
  • builtinPasswordSig
  • builtinRandomBytesSig
  • builtinMD5Sig
  • builtinSHA1Sig
  • builtinSHA2Sig
  • builtinCompressSig
  • builtinUncompressSig
  • builtinDatabaseSig
  • builtinCurrentUserSig
  • builtinCurrentRoleSig
  • builtinUserSig
  • builtinVersionSig
  • builtinTiDBVersionSig
  • builtinJSONTypeSig
  • builtinJSONUnquoteSig
  • builtinJSONQuoteSig
  • builtinConvSig
  • builtinStringAnyValueSig
  • builtinInetNtoaSig @Reminiscent expression: implement vectorized evaluation for builtinInetNtoaSig #12088
  • builtinInet6AtonSig
  • builtinInet6NtoaSig
  • builtinNameConstStringSig
  • builtinUUIDSig
  • builtinRowSig
  • builtinSetVarSig
  • builtinGetVarSig
  • builtinGetParamStringSig
  • builtinConcatSig
  • builtinConcatWSSig
  • builtinLeftBinarySig
  • builtinLeftSig
  • builtinRightBinarySig
  • builtinRightSig
  • builtinRepeatSig @qw4990 expression: implement vectorized evaluation for builtinRepeatSig  #12014
  • builtinLowerSig @qw4990 expression: implement vectorized evaluation for builtinLowerStr #12013
  • builtinReverseBinarySig
  • builtinReverseSig
  • builtinSpaceSig
  • builtinUpperSig
  • builtinReplaceSig
  • builtinConvertSig
  • builtinSubstringBinary2ArgsSig
  • builtinSubstring2ArgsSig
  • builtinSubstringBinary3ArgsSig
  • builtinSubstring3ArgsSig
  • builtinSubstringIndexSig
  • builtinHexStrArgSig
  • builtinHexIntArgSig
  • builtinUnHexSig
  • builtinTrim1ArgSig
  • builtinTrim2ArgsSig
  • builtinTrim3ArgsSig
  • builtinLTrimSig
  • builtinRTrimSig
  • builtinLpadBinarySig
  • builtinLpadSig
  • builtinRpadBinarySig
  • builtinRpadSig
  • builtinCharSig
  • builtinMakeSetSig
  • builtinOctIntSig
  • builtinOctStringSig
  • builtinQuoteSig
  • builtinBinSig
  • builtinEltSig
  • builtinExportSet3ArgSig
  • builtinExportSet4ArgSig
  • builtinExportSet5ArgSig
  • builtinFormatWithLocaleSig
  • builtinFormatSig
  • builtinFromBase64Sig
  • builtinToBase64Sig
  • builtinInsertBinarySig
  • builtinInsertSig
  • builtinDateFormatSig
  • builtinMonthNameSig
  • builtinDayNameSig
  • builtinFromUnixTime2ArgSig
  • builtinGetFormatSig
  • builtinAddTimeStringNullSig
  • builtinAddStringAndDurationSig
  • builtinAddStringAndStringSig
  • builtinAddDateAndDurationSig
  • builtinAddDateAndStringSig
  • builtinTimeFormatSig
  • builtinTimestampAddSig

Prefer to implement them by go generate, see https://docs.google.com/document/d/17XdYo_EwYaWANqbjS3i3OVSz3oLlovU2fIo1bRx4YqA/edit#, and find your interest and take a job.

builtinSubDateAndDurationSig
builtinSubDateAndStringSig
builtinSubDatetimeAndDurationSig
builtinSubDatetimeAndStringSig
builtinSubDurationAndDurationSig
builtinSubDurationAndStringSig
builtinSubStringAndDurationSig
builtinSubStringAndStringSig
builtinSubTimeDateTimeNullSig
builtinSubTimeDurationNullSig
builtinSubTimeStringNullSig
@qw4990 qw4990 added type/enhancement The issue or PR belongs to an enhancement. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. component/expression labels Sep 10, 2019
@qw4990 qw4990 mentioned this issue Sep 10, 2019
Closed
@b41sh b41sh mentioned this issue Sep 10, 2019
Merged
This was referenced Sep 17, 2019
Merged
Merged
Merged
This was referenced Sep 21, 2019
Merged
Merged
@shihongzhi
Copy link
Member

Let me fix:
builtinLeftSig
builtinRightSig

@tsthght
Copy link
Contributor

tsthght commented Sep 23, 2019 •
edited
Loading

Let me fix:
builtinBinSig
builtinOctIntSig
builtinUnHexSig
builtinTimeFormatSig
builtinCastIntAsStringSig
builtinCastRealAsStringSig
builtinCastDecimalAsStringSig
builtinCastStringAsStringSig
builtinCastTimeAsStringSig
builtinCastDurationAsStringSig
builtinCastJSONAsStringSig

@shihongzhi
Copy link
Member

Let me fix:
builtinTrim1ArgSig
builtinTrim2ArgsSig
builtinTrim3ArgsSig
builtinLTrimSig
builtinRTrimSig

This was referenced Sep 25, 2019
Merged
Merged
This was referenced Sep 26, 2019
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 30, 2019
Merged
Merged
Merged
Merged
This was referenced Oct 8, 2019
Merged
Merged
Merged
Merged
Merged
@js00070 js00070 mentioned this issue Nov 17, 2019
Merged
@XuelinLuu
Copy link

/pick-up-challenge

@sre-bot
Copy link
Contributor

sre-bot commented Nov 18, 2019

You can file a PR directly without picking up because this issue it's a collection of multiple tasks. Each PR related to this issue will rewarded 50 score when merged.

This was referenced Nov 18, 2019
Merged
Merged
@js00070 js00070 mentioned this issue Nov 18, 2019
Merged
@icditwang icditwang mentioned this issue Nov 19, 2019
Merged
This was referenced Nov 19, 2019
Merged
Merged
Closed
@SilvaXiang SilvaXiang mentioned this issue Nov 22, 2019
Merged
This was referenced Nov 26, 2019
Closed
Merged
@dengsigua dengsigua mentioned this issue Nov 27, 2019
Merged
@b41sh b41sh mentioned this issue Nov 28, 2019
Merged
This was referenced Nov 30, 2019
Closed
Closed
@tangwz tangwz mentioned this issue Dec 4, 2019
Closed
This was referenced Dec 12, 2019
Closed
Merged
Merged
@shihongzhi shihongzhi mentioned this issue Dec 16, 2019
Closed
@ZiheLiu ZiheLiu mentioned this issue Jan 20, 2020
Merged
@lance6716
Copy link
Contributor

lance6716 commented Feb 24, 2020 •
edited
Loading

let me fix:
builtinFormatWithLocaleSig
builtinDateFormatSig

This was referenced Feb 24, 2020
Merged
Merged
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 15, 2020

Close due to finish. Thanks to all our contributors.

@qw4990 qw4990 closed this as completed Apr 15, 2020
@lzmhhh123 lzmhhh123 mentioned this issue Dec 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/expression good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests