expression:implement vectorized evaluation for builtinInsertBinarySig #13556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. If your PR get merged, you will be rewarded 50 points. |
ghost
requested review from
qw4990 and
SunRunAway
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #13556 +/- ##
===========================================
Coverage 80.0322% 80.0322%
===========================================
Files 472 472
Lines 115922 115922
===========================================
Hits 92775 92775
Misses 15875 15875
Partials 7272 7272 |
SunRunAway
reviewed
Nov 19, 2019
SunRunAway
added
status/LGT1
qw4990
added
status/can-merge
|
/run-all-tests |
|
@icditwang complete task #12106 and get 50 score, currerent score 350. |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PCP #12106
What problem does this PR solve?
implement vectorized evaluation for builtinInsertBinarySig
What is changed and how it works?
Check List
Tests